Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #83145

Closed
wants to merge 41 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
1ba71ab
Inline Attribute::has_name
tmiasko Mar 11, 2021
4943190
Validate rustc_layout_scalar_valid_range_{start,end} attributes
tmiasko Mar 11, 2021
2eeddcc
Add reproduction test
oli-obk Mar 4, 2021
7154563
Use tracing instrumentation for better bug diagnosing
oli-obk Mar 5, 2021
b42e258
Make regression test succeed as long as it ICEs
oli-obk Mar 5, 2021
7a318ae
Delete non-revision ui test output file if revisions are used
oli-obk Mar 5, 2021
375e243
Replace `type_alias_impl_trait` by `min_type_alias_impl_trait` with n…
oli-obk Mar 12, 2021
ed4c2d1
Add a test showing how `impl_trait_in_bindings` is a breaking change
oli-obk Mar 12, 2021
bc9019f
Special case type aliases from impl trait in const/static types
oli-obk Mar 12, 2021
9a36840
Only allow tait defining uses in function and method return position
oli-obk Mar 12, 2021
6fb5716
🍼 for tidy
oli-obk Mar 12, 2021
c74fdf0
More precise spans for HIR paths
petrochenkov Mar 13, 2021
9613a88
Refactor `check_doc_attrs` body
camelid Mar 13, 2021
7189c05
Lint non-meta doc attributes
camelid Mar 13, 2021
7e972a3
Report error for each invalid nested attribute
camelid Mar 11, 2021
fe64970
Add another test case
camelid Mar 12, 2021
5134047
Add hyphen to "crate level"
camelid Mar 13, 2021
13884dc
Update `rustdoc-ui` versions of the `doc-attr` test
camelid Mar 14, 2021
e161a2f
Remove unused `opt_local_def_id_to_hir_id` function
jyn514 Mar 14, 2021
71a784d
Fix a typo in `swap_nonoverlapping_bytes`
hiyoko3m Mar 12, 2021
5ec0540
Fix a typo in thread_local_dtor.rs
hiyoko3m Mar 14, 2021
6ddd840
Minor refactoring in try_index_step
osa1 Mar 14, 2021
14038c7
Remove duplicate asserts, replace eq assert with assert_eq
osa1 Mar 14, 2021
13076f9
Tweak diagnostics
camelid Mar 14, 2021
8f40e11
Use pretty-printer instead of `span_to_snippet`
camelid Mar 14, 2021
7429c68
Don't encode file information for span with a dummy location
Aaron1011 Mar 14, 2021
f190bc4
Introduce `proc_macro_back_compat` lint, and emit for `time-macros-impl`
Aaron1011 Mar 14, 2021
4bc1434
Explain each variant of TAIT usage with examples
oli-obk Mar 15, 2021
ebe51cf
:arrow_up: rust-analyzer
lnicola Mar 15, 2021
5eae9af
Custom error on literal names from other languages
syvb Mar 15, 2021
239f32e
Rollup merge of #82898 - oli-obk:tait_🧊, r=nikomatsakis
Dylan-DPC Mar 15, 2021
b9f52df
Rollup merge of #82989 - Smittyvb:other-lang-literal-errors, r=varkor
Dylan-DPC Mar 15, 2021
c109e9e
Rollup merge of #83054 - tmiasko:rustc_layout_scalar_valid_range, r=d…
Dylan-DPC Mar 15, 2021
f49091d
Rollup merge of #83092 - petrochenkov:qspan, r=estebank
Dylan-DPC Mar 15, 2021
3ec47de
Rollup merge of #83098 - camelid:more-doc-attr-check, r=davidtwco
Dylan-DPC Mar 15, 2021
65474b2
Rollup merge of #83108 - jyn514:remove-unused, r=estebank
Dylan-DPC Mar 15, 2021
96e0c44
Rollup merge of #83110 - hyksm:fix-typo, r=jonas-schievink
Dylan-DPC Mar 15, 2021
1647646
Rollup merge of #83113 - osa1:refactor_try_index_step, r=jonas-schievink
Dylan-DPC Mar 15, 2021
ebba9a4
Rollup merge of #83127 - Aaron1011:time-macros-impl-warn, r=petrochenkov
Dylan-DPC Mar 15, 2021
99252bf
Rollup merge of #83132 - Aaron1011:fix/incr-cache-dummy, r=estebank
Dylan-DPC Mar 15, 2021
97423d5
Rollup merge of #83141 - lnicola:rust-analyzer-2021-03-15, r=jonas-sc…
Dylan-DPC Mar 15, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test showing how impl_trait_in_bindings is a breaking change
  • Loading branch information
oli-obk committed Mar 12, 2021
commit ed4c2d1f317b0e70f21541fd341838322c3d888a
17 changes: 17 additions & 0 deletions src/test/ui/mir/issue-75053.full_tait.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
warning: the feature `type_alias_impl_trait` is incomplete and may not be safe to use and/or cause compiler crashes
--> $DIR/issue-75053.rs:5:32
|
LL | #![cfg_attr(full_tait, feature(type_alias_impl_trait))]
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(incomplete_features)]` on by default
= note: see issue #63063 <https://github.com/rust-lang/rust/issues/63063> for more information

error: fatal error triggered by #[rustc_error]
--> $DIR/issue-75053.rs:51:1
|
LL | fn main() {
| ^^^^^^^^^

error: aborting due to previous error; 1 warning emitted

24 changes: 24 additions & 0 deletions src/test/ui/mir/issue-75053.in_bindings.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
warning: the feature `impl_trait_in_bindings` is incomplete and may not be safe to use and/or cause compiler crashes
--> $DIR/issue-75053.rs:7:34
|
LL | #![cfg_attr(in_bindings, feature(impl_trait_in_bindings))]
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(incomplete_features)]` on by default
= note: see issue #63065 <https://github.com/rust-lang/rust/issues/63065> for more information

error[E0282]: type annotations needed
--> $DIR/issue-75053.rs:53:38
|
LL | type O;
| ------- `<Self as MyIndex<T>>::O` defined here
...
LL | let _pos: Phantom1<DummyT<()>> = Scope::new().my_index();
| ^^^^^^^^^^-------------
| |
| this method call resolves to `<Self as MyIndex<T>>::O`
| cannot infer type for type parameter `T`

error: aborting due to previous error; 1 warning emitted

For more information about this error, try `rustc --explain E0282`.
8 changes: 8 additions & 0 deletions src/test/ui/mir/issue-75053.min_tait.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
error: fatal error triggered by #[rustc_error]
--> $DIR/issue-75053.rs:51:1
|
LL | fn main() {
| ^^^^^^^^^

error: aborting due to previous error

11 changes: 9 additions & 2 deletions src/test/ui/mir/issue-75053.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
// compile-flags: -Z mir-opt-level=3
// build-pass

#![feature(type_alias_impl_trait)]
// revisions: min_tait full_tait in_bindings
#![feature(min_type_alias_impl_trait, rustc_attrs)]
#![cfg_attr(full_tait, feature(type_alias_impl_trait))]
//[full_tait]~^ WARN incomplete
#![cfg_attr(in_bindings, feature(impl_trait_in_bindings))]
//[in_bindings]~^ WARN incomplete

use std::marker::PhantomData;

Expand Down Expand Up @@ -43,6 +47,9 @@ impl<T: MyFrom<Phantom2<DummyT<U>>>, U> MyIndex<Phantom1<T>> for Scope<U> {
}
}

#[rustc_error]
fn main() {
//[min_tait,full_tait]~^ ERROR rustc_error
let _pos: Phantom1<DummyT<()>> = Scope::new().my_index();
//[in_bindings]~^ ERROR type annotations needed
}