make suggest_setup help messages better#82211
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
suggest_setup help messages bettersuggest_setup help messages better
|
I used to have an Because neither just |
|
Thanks, sounds like we could improve the Windows experience but this change won't hurt anything. @bors r+ rollup |
|
📌 Commit e13f25c has been approved by |
|
@jyn514 just an idea: couldn't we detect which OS the user was on and give a message based on that (that's for another PR though) |
For something this small I don't think it's worth it. I would rather try to get |
Rollup of 8 pull requests Successful merges: - rust-lang#82055 (Add diagnostics for specific cases for const/type mismatch err) - rust-lang#82155 (Use !Sync std::lazy::OnceCell in usefulness checking) - rust-lang#82202 (add specs for riscv32/riscv64 musl targets) - rust-lang#82203 (Move some tests to more reasonable directories - 4) - rust-lang#82211 (make `suggest_setup` help messages better) - rust-lang#82212 (Remove redundant rustc_data_structures path component) - rust-lang#82240 (remove useless ?s (clippy::needless_question_marks)) - rust-lang#82243 (Add more intra-doc links to std::io) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
@scottmcm @jyn514 I'm not sure why, but |
When I first built the compiler and didn't create a
config.toml.example, the following was emitted:I ran
x.py setupbut got an error so in this PR I made the help messages a little clearer.