-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 15 pull requests #81784
Rollup of 15 pull requests #81784
Commits on Jan 27, 2021
-
Don't build remote-test-server with the stage0 toolchain
Newly added targets aren't available on the stage0 toolchain.
Configuration menu - View commit details
-
Copy full SHA for a072ecb - Browse repository at this point
Copy the full SHA a072ecbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5482a8 - Browse repository at this point
Copy the full SHA b5482a8View commit details
Commits on Jan 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a2f5c72 - Browse repository at this point
Copy the full SHA a2f5c72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c60d27 - Browse repository at this point
Copy the full SHA 1c60d27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3106de5 - Browse repository at this point
Copy the full SHA 3106de5View commit details -
rustdoc: Move
display_fn
struct insidedisplay_fn
This makes it clear that it's an implementation detail of `display_fn` and shouldn't be used elsewhere, and it enforces in the compiler that no one else can use it.
Configuration menu - View commit details
-
Copy full SHA for c34faad - Browse repository at this point
Copy the full SHA c34faadView commit details
Commits on Jan 30, 2021
-
Expose correct symlink API on WASI
As described in rust-lang#68574, the currently exposed API for symlinks is, in fact, a thin wrapper around the corresponding syscall, and not suitable for public usage. The reason is that the 2nd param in the call is expected to be a handle of a "preopened directory" (a WASI concept for exposing dirs), and the only way to retrieve such handle right now is by tinkering with a private `__wasilibc_find_relpath` API, which is an implementation detail and definitely not something we want users to call directly. Making matters worse, the semantics of this param aren't obvious from its name (`fd`), and easy to misinterpret, resulting in people trying to pass a handle of the target file itself (as in vitiral/path_abs#50), which doesn't work as expected. I did a codesearch among open-source repos, and the usage above is so far the only usage of this API at all, but we should fix it before more people start using it incorrectly. While this is technically a breaking API change, I believe it's a justified one, as 1) it's OS-specific and 2) there was strictly no way to correctly use the previous form of the API, and if someone does use it, they're likely doing it wrong like in the example above. The new API does not lead to the same confusion, as it mirrors `std::os::unix::fs::symlink` and `std::os::windows::fs::symlink_{file,dir}` variants by accepting source/target paths. Fixes rust-lang#68574.
Configuration menu - View commit details
-
Copy full SHA for 5882cce - Browse repository at this point
Copy the full SHA 5882cceView commit details
Commits on Feb 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6e6608d - Browse repository at this point
Copy the full SHA 6e6608dView commit details
Commits on Feb 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1578f2e - Browse repository at this point
Copy the full SHA 1578f2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b1bef - Browse repository at this point
Copy the full SHA f4b1befView commit details -
Add more information to the error code for 'crate not found'
This comes up a lot when bootstrapping.
Configuration menu - View commit details
-
Copy full SHA for 82914a5 - Browse repository at this point
Copy the full SHA 82914a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b5d018 - Browse repository at this point
Copy the full SHA 3b5d018View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50e394a - Browse repository at this point
Copy the full SHA 50e394aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 031cce8 - Browse repository at this point
Copy the full SHA 031cce8View commit details
Commits on Feb 4, 2021
-
add test to ensure object-safety This allows for runtime polymorphic allocators
Configuration menu - View commit details
-
Copy full SHA for d06384a - Browse repository at this point
Copy the full SHA d06384aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdaf603 - Browse repository at this point
Copy the full SHA fdaf603View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16af7bf - Browse repository at this point
Copy the full SHA 16af7bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 760a665 - Browse repository at this point
Copy the full SHA 760a665View commit details -
Configuration menu - View commit details
-
Copy full SHA for da2cf9b - Browse repository at this point
Copy the full SHA da2cf9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a68966 - Browse repository at this point
Copy the full SHA 6a68966View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e92015 - Browse repository at this point
Copy the full SHA 9e92015View commit details -
Cleanup rustdoc pass descriptions a bit
Also changed a couple of comments from "intra-doc-links" to "intra-doc links" (my understanding is that "intra-doc links" is the standard way to refer to them).
Configuration menu - View commit details
-
Copy full SHA for b080d1c - Browse repository at this point
Copy the full SHA b080d1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12d411f - Browse repository at this point
Copy the full SHA 12d411fView commit details
Commits on Feb 5, 2021
-
Update LayoutError/LayoutErr stability attributes
Jacob Hughes committedFeb 5, 2021 Configuration menu - View commit details
-
Copy full SHA for 0c3a7d8 - Browse repository at this point
Copy the full SHA 0c3a7d8View commit details -
Indicate change in RSS from start to end of pass in time-passes output
Previously, this was omitted because it could be misleading, but the functionality seems too useful not to include.
Configuration menu - View commit details
-
Copy full SHA for 4253919 - Browse repository at this point
Copy the full SHA 4253919View commit details -
Configuration menu - View commit details
-
Copy full SHA for 573f1c0 - Browse repository at this point
Copy the full SHA 573f1c0View commit details -
Rollup merge of rust-lang#79554 - b-naber:generic-associated-types-in…
…-trait-paths, r=jackh726 Generic associated types in trait paths This is the second part of rust-lang#78978 This should fix: Fixes rust-lang#67510 Fixes rust-lang#68648 Fixes rust-lang#68649 Fixes rust-lang#68650 Fixes rust-lang#68652 Fixes rust-lang#74684 Fixes rust-lang#76535 Fixes rust-lang#79422 Fixes rust-lang#80433 and implement the remaining functionality needed for rust-lang#44265 r? ``@matthewjasper``
Configuration menu - View commit details
-
Copy full SHA for deec6a9 - Browse repository at this point
Copy the full SHA deec6a9View commit details -
Rollup merge of rust-lang#80726 - lcnr:unsize-query, r=oli-obk
relax adt unsizing requirements Changes unsizing of structs in case the last struct field shares generic params with other adt fields which do not change. This change is currently insta stable and changes the language, so it at least requires a lang fcp. I feel like the current state is fairly unintuitive. An example for what's now allowed would be https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6dd331d23f5c9ffc8c978175aae2e967 ```rust struct A<T, U: ?Sized>(T, B<T, U>); // previously ERR // struct A<T, U: ?Sized>(T, B<[u32; 1], U>); // ok struct B<T, U: ?Sized>(T, U); fn main() { let x = A([0; 1], B([0; 1], [0; 1])); let y: &A<[u32; 1], [u32]> = &x; assert_eq!(y.1.1.len(), 1); } ```
Configuration menu - View commit details
-
Copy full SHA for 676ff77 - Browse repository at this point
Copy the full SHA 676ff77View commit details -
Rollup merge of rust-lang#81307 - estebank:invalid-byte-str-span, r=p…
…etrochenkov Handle `Span`s for byte and raw strings and add more detail CC rust-lang#81208.
Configuration menu - View commit details
-
Copy full SHA for 8d49ca1 - Browse repository at this point
Copy the full SHA 8d49ca1View commit details -
Rollup merge of rust-lang#81318 - CraftSpider:json-trait-fix, r=jyn514
rustdoc-json: Fix has_body Previously, `has_body` was always true. Now propagate the type of the method to set it correctly. Relies on rust-lang#81287, that will need to be merged first.
Configuration menu - View commit details
-
Copy full SHA for 0493e3a - Browse repository at this point
Copy the full SHA 0493e3aView commit details -
Rollup merge of rust-lang#81456 - Amanieu:remote-test-server, r=Amanieu
Make remote-test-server easier to use with new targets While testing rust-lang#81455 I encountered 2 issues with `remote-test-server`: - It is built with the stage 0 toolchain, which does not support a newly added target. - It overwrites `LD_LIBRARY_PATH` instead of appending to it, which prevents the use of a custom sysroot for target libraries.
Configuration menu - View commit details
-
Copy full SHA for b5438e2 - Browse repository at this point
Copy the full SHA b5438e2View commit details -
Rollup merge of rust-lang#81497 - camelid:rustdoc-display_fn-remove-c…
…ell, r=jyn514 rustdoc: Move `display_fn` struct inside `display_fn` This makes it clear that it's an implementation detail of `display_fn` and shouldn't be used elsewhere, and it enforces in the compiler that no one else can use it. r? ````@GuillaumeGomez````
Configuration menu - View commit details
-
Copy full SHA for 2451bf9 - Browse repository at this point
Copy the full SHA 2451bf9View commit details -
Rollup merge of rust-lang#81500 - CraftSpider:union-kind, r=jyn514
Remove struct_type from union output Also bumps the format number and adds a test Rationale: It's illegal to have unions of the form `union Union(i32, f32);`, or `union Union;`. The struct_type field was recently removed from the rustdoc Union AST, at which time this field was changed to always just read "union". It makes sense to completely remove it, as it provides no information.
Configuration menu - View commit details
-
Copy full SHA for e98e42b - Browse repository at this point
Copy the full SHA e98e42bView commit details -
Rollup merge of rust-lang#81542 - RReverser:wasi-symlink, r=alexcrichton
Expose correct symlink API on WASI As described in rust-lang#68574, the currently exposed API for symlinks is, in fact, a thin wrapper around the corresponding syscall, and not suitable for public usage. The reason is that the 2nd param in the call is expected to be a handle of a "preopened directory" (a WASI concept for exposing dirs), and the only way to retrieve such handle right now is by tinkering with a private `__wasilibc_find_relpath` API, which is an implementation detail and definitely not something we want users to call directly. Making matters worse, the semantics of this param aren't obvious from its name (`fd`), and easy to misinterpret, resulting in people trying to pass a handle of the target file itself (as in vitiral/path_abs#50), which doesn't work as expected. I did a [codesearch among open-source repos](https://sourcegraph.com/search?q=std%3A%3Aos%3A%3Awasi%3A%3Afs%3A%3Asymlink&patternType=literal), and the usage above is so far the only usage of this API at all, but we should fix it before more people start using it incorrectly. While this is technically a breaking API change, I believe it's a justified one, as 1) it's OS-specific and 2) there was strictly no way to correctly use the previous form of the API, and if someone does use it, they're likely doing it wrong like in the example above. The new API does not lead to the same confusion, as it mirrors `std::os::unix::fs::symlink` and `std::os::windows::fs::symlink_{file,dir}` variants by accepting source/target paths. Fixes rust-lang#68574. r? ``@alexcrichton``
Configuration menu - View commit details
-
Copy full SHA for ce1020f - Browse repository at this point
Copy the full SHA ce1020fView commit details -
Rollup merge of rust-lang#81676 - jyn514:crate-not-found, r=oli-obk
Add more information to the error code for 'crate not found' This comes up a lot when bootstrapping.
Configuration menu - View commit details
-
Copy full SHA for 29371c2 - Browse repository at this point
Copy the full SHA 29371c2View commit details -
Rollup merge of rust-lang#81682 - JulianKnodt:bit_set_iter_benchmarks…
…, r=oli-obk Add additional bitset benchmarks Add additional benchmarks for operations in bitset, I realize that it was a bit lacking when I intended to optimize it earlier, so I was hoping to put some in so I can verify my work later.
Configuration menu - View commit details
-
Copy full SHA for 21c276f - Browse repository at this point
Copy the full SHA 21c276fView commit details -
Rollup merge of rust-lang#81730 - RustyYato:object-safe-allocator, r=…
…Amanieu Make `Allocator` object-safe This allows rust-lang/wg-allocators#83: polymorphic allocators
Configuration menu - View commit details
-
Copy full SHA for ff3c85f - Browse repository at this point
Copy the full SHA ff3c85fView commit details -
Rollup merge of rust-lang#81763 - camelid:rustdoc-passes-desc-up, r=G…
…uillaumeGomez Cleanup rustdoc pass descriptions a bit Also changed a couple of comments from "intra-doc-links" to "intra-doc links" (my understanding is that "intra-doc links" is the standard way to refer to them).
Configuration menu - View commit details
-
Copy full SHA for 469d535 - Browse repository at this point
Copy the full SHA 469d535View commit details -
Rollup merge of rust-lang#81767 - exrook:layout-error-stability, r=Ma…
…rk-Simulacrum Update LayoutError/LayoutErr stability attributes `LayoutError` ended up not making it into 1.49.0, updating the stability attributes to reflect that. I also pushed `LayoutErr` deprecation back a release to allow 2 releases before the deprecation comes into effect. This change should be backported to beta.
Configuration menu - View commit details
-
Copy full SHA for e077dff - Browse repository at this point
Copy the full SHA e077dffView commit details -
Rollup merge of rust-lang#81771 - tgnottingham:time-passes-rss-delta,…
… r=oli-obk Indicate change in RSS from start to end of pass in time-passes output Previously, this was omitted because it could be misleading, but the functionality seems too useful not to include. r? ``@oli-obk``
Configuration menu - View commit details
-
Copy full SHA for 08d8fc1 - Browse repository at this point
Copy the full SHA 08d8fc1View commit details -
Rollup merge of rust-lang#81781 - m-ou-se:fix-ci, r=pietroalbini
Fix `install-awscli.sh` error in CI This fixes the `install-awscli.sh` error about missing `'bdist_wheel'`.
Configuration menu - View commit details
-
Copy full SHA for 2383cd4 - Browse repository at this point
Copy the full SHA 2383cd4View commit details