Cleanup strs #7996
Closed
Cleanup strs #7996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/libstd/str.rs
Outdated
Contributor
There was a problem hiding this comment.
This should probably have a warning about maintaining the invariant that the string is valid UTF8, and should definitely take &mut self rather than &self.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that. I'll add the &mut self and a warning.
Contributor
Author
|
@huonw: Updated the pull request address your suggestion, and also added a couple more cleanup functions. |
Contributor
|
I would think (The whole matter of null termination remains, to this day, contentious. As you know, in #7235) |
Contributor
Author
These uses are assuming the strings are null terminated, so it should be using `as_c_str` instead of `as_buf`
This eliminates a copy and fixes a FIXME.
Contributor
Author
|
@graydon: Updated the pull request to add |
bors
added a commit
that referenced
this pull request
Jul 24, 2013
This is a cleanup pull request that does: * removes `os::as_c_charp` * moves `str::as_buf` and `str::as_c_str` into `StrSlice` * converts some functions from `StrSlice::as_buf` to `StrSlice::as_c_str` * renames `StrSlice::as_buf` to `StrSlice::as_imm_buf` (and adds `StrSlice::as_mut_buf` to match `vec.rs`. * renames `UniqueStr::as_bytes_with_null_consume` to `UniqueStr::to_bytes` * and other misc cleanups and minor optimizations
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 23, 2021
…arth Add test case for RESULT_MAP_OR_INTO_OPTION just added test case for RESULT_MAP_OR_INTO_OPTION. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup pull request that does:
os::as_c_charpstr::as_bufandstr::as_c_strintoStrSliceStrSlice::as_buftoStrSlice::as_c_strStrSlice::as_buftoStrSlice::as_imm_buf(and addsStrSlice::as_mut_bufto matchvec.rs.UniqueStr::as_bytes_with_null_consumetoUniqueStr::to_bytes