rustc_codegen_ssa: use bitcasts instead of type punning for scalar transmutes. #79801
Conversation
rust-highfive
added
the
S-waiting-on-review
nagisa
left a comment
nagisa
left a comment
There was a problem hiding this comment.
LGTM. r=me after tests for the ptr special case are added (or found to already exist)
| #[no_mangle] | ||
| pub unsafe fn byte_to_bool(byte: u8) -> bool { | ||
| std::mem::transmute(byte) | ||
| } |
There was a problem hiding this comment.
Can you add special test around the pointer special case? (ptr->ptr, ptr->int, ...) I don't anticipate this PR breaking it, but it would be good to have it to be sure.
There was a problem hiding this comment.
Good point, added ptr->ptr, ptr->int, int->ptr, and included comments with what they might become in the future.
|
@bors r=nagisa |
|
📌 Commit 5c1d2ce has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 5c1d2ce with merge ed6739a8568aa29b8a1aa17d7af76b8e1859cc47... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Oops, guess the tests needs @bors r=nagisa |
|
📌 Commit 718fba9 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
5 participants
This specifically helps with
f32<->u32(from_bits,to_bits) in Rust-GPU (rustc_codegen_spirv), where (AFAIK) we don't yet have enough infrastructure to turn type punning memory accesses into SSA bitcasts.(There may be more instances, but the one I've seen myself is
f32::signumfromnum-traitsinspecting e.g. the sign bit)Sadly I've had to make an exception for
transmutes between pointers and non-pointers, as LLVM disallows usingbitcastfor them.r? @nagisa cc @khyperia