Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not visit ForeignItemRef for HIR indexing and validation. #79511

Merged
merged 1 commit into from
Nov 29, 2020

Conversation

cjgillot
Copy link
Contributor

Similarly to what is done for ImplItemRef and TraitItemRef.

Fixes #79487

r? @lcnr

Similarly to what is done for ImplItemRef and TraitItemRef.

Fixes rust-lang#79487
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2020
@lcnr
Copy link
Contributor

lcnr commented Nov 28, 2020

lgtm, thanks

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Nov 28, 2020

📌 Commit 5bd1979 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2020
@bors
Copy link
Contributor

bors commented Nov 28, 2020

⌛ Testing commit 5bd1979 with merge 914d07a...

@bors
Copy link
Contributor

bors commented Nov 29, 2020

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 914d07a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 29, 2020
@bors bors merged commit 914d07a into rust-lang:master Nov 29, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 29, 2020
@cjgillot cjgillot deleted the fitem-2 branch November 29, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal Compiler Error when compiling the ring crate after updating to the 11-27 nightly
5 participants