Skip to content

Update Clippy #79228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 149 commits into from
Nov 24, 2020
Merged

Update Clippy #79228

Changes from 1 commit
Commits
Show all changes
149 commits
Select commit Hold shift + click to select a range
be81608
split `interior_mutable_const` tests and clean it
rail-rain Sep 30, 2020
f58a169
fix a FP in `interior_mutable_const`
rail-rain Sep 30, 2020
7c74d87
Fix vec_box scope error
camsteffen Oct 30, 2020
c0d1002
Fix unnecessary_lazy_eval suggestion applicability
camsteffen Oct 30, 2020
158bf9a
Fix incorrect suggestion for macro expansion in `deref_addrof` lint
ThibsG Oct 31, 2020
343bdb3
Give better suggestion by working on span on `deref_addrof` lint
ThibsG Nov 2, 2020
ce98468
Fix incorrect suggestion when from expansion in `try_err` lint
ThibsG Nov 2, 2020
a6611de
Include bindings as machine applicable
camsteffen Nov 2, 2020
89fa373
rustc_ast: Do not panic by default when visiting macro calls
petrochenkov Nov 3, 2020
c2a769f
rustc_ast: `visit_mac` -> `visit_mac_call`
petrochenkov Nov 3, 2020
a4acb31
Fix example for cargo common data
Urcra Nov 4, 2020
fd8dece
Readme improvements
camsteffen Nov 3, 2020
bc27d14
Add string_from_utf8_as_bytes linter
patrickelectric Oct 8, 2020
f83762b
Skip rustfmt as it is wanted for this test
ThibsG Nov 2, 2020
3424419
Merge commit 'b20d4c155d2fe3a8391f86dcf9a8c49e17188703' into clippyup
flip1995 Nov 5, 2020
83e75f9
Fix incorrect suggestion for `try_err` lint when `Err` arg is itself …
ThibsG Nov 5, 2020
1e4ce0f
Fix `await_holding_refcell_ref` examples for clarify
JohnTitor Nov 5, 2020
1624b00
Fix suggestion to add unneeded space in `manual_async`
giraffate Nov 5, 2020
5f57608
do not trigger map_clone in the case of &mut
alex-700 Nov 6, 2020
b7892c6
Refactor to make getting position just before RArrow a common function
giraffate Nov 6, 2020
8242b2f
Remove needless allow
ThibsG Oct 30, 2020
2ea08e1
Auto merge of #6294 - giraffate:fix_suggestion_to_add_space_in_manual…
bors Nov 6, 2020
5253595
FROM_ITER_INSTEAD_OF_COLLECT: avoid unwrapping unconditionally
matthiaskrgr Nov 6, 2020
4bbef42
Auto merge of #6272 - camsteffen:unnecesary-lazy-eval-type, r=llogiq
bors Nov 7, 2020
694cec1
Auto merge of #6110 - rail-rain:care_enums_non_copy_const, r=llogiq
bors Nov 7, 2020
92ba075
Auto merge of #6134 - patrickelectric:as_utf8, r=llogiq
bors Nov 7, 2020
4aca13f
Auto merge of #6287 - camsteffen:readme, r=llogiq
bors Nov 7, 2020
5effc99
Auto merge of #6298 - JohnTitor:fix-example, r=llogiq
bors Nov 7, 2020
c015622
Auto merge of #6304 - matthiaskrgr:crash_6302, r=llogiq
bors Nov 7, 2020
96d5f45
Auto merge of #6301 - alex-700:fix-map-clone, r=matthiaskrgr
bors Nov 8, 2020
c6a91df
Enable empty_loop lint for no_std crates
josephlr Oct 23, 2020
3579b7d
Update clippy_lints/src/loops.rs
josephlr Nov 4, 2020
00dee9d
Update reference files
flip1995 Nov 8, 2020
abfa331
Auto merge of #6205 - josephlr:empty-loop2, r=flip1995
bors Nov 8, 2020
f1f780c
Add let_underscore_drop
smoelius Nov 7, 2020
b1faa7f
Auto merge of #6271 - camsteffen:vec-box-import, r=flip1995
bors Nov 8, 2020
9c6a0b9
Update references
smoelius Nov 8, 2020
7079de9
Auto merge of #6293 - Urcra:lint-example-fix, r=flip1995
bors Nov 8, 2020
7c612c1
Force contributors/reviewers to set _some_ changelog entry
flip1995 Nov 8, 2020
040d0ca
Auto merge of #6288 - flip1995:changelog_internal, r=matthiaskrgr
bors Nov 8, 2020
b099406
Make KNOW_TYPES static
camsteffen Oct 29, 2020
9cab084
Fix or_fun_call for index operator
camsteffen Oct 29, 2020
2067a01
Auto merge of #6267 - camsteffen:or-fun-idx, r=flip1995
bors Nov 8, 2020
aa6bf1f
Update clippy_lints/src/let_underscore.rs
smoelius Nov 8, 2020
9751cba
Update clippy_lints/src/let_underscore.rs
smoelius Nov 8, 2020
8211b59
Update clippy_lints/src/let_underscore.rs
smoelius Nov 8, 2020
40d7af5
Update lints
smoelius Nov 8, 2020
8845f10
Do not collect tokens for doc comments
petrochenkov Nov 5, 2020
06e81bb
Update references
smoelius Nov 8, 2020
d212c38
Auto merge of #6278 - ThibsG:DerefAddrOf, r=llogiq
bors Nov 9, 2020
4852cca
Allow `let_underscore_drop` in `filter_methods` test
smoelius Nov 9, 2020
6294300
Rollup merge of #78710 - petrochenkov:macvisit, r=davidtwco
Dylan-DPC Nov 9, 2020
dd826b4
Auto merge of #6305 - smoelius:master, r=flip1995
bors Nov 9, 2020
3ea6f77
Merge remote-tracking branch 'upstream/master' into rustup
ebroto Nov 10, 2020
effcb52
Run cargo dev fmt
ebroto Nov 10, 2020
467bf95
Auto merge of #6319 - ebroto:rustup, r=ebroto
bors Nov 10, 2020
d0858d0
Auto merge of #6303 - ThibsG:OptionOptionSerde, r=ebroto
bors Nov 10, 2020
7690944
Fix map_clone with deref and clone
camsteffen Oct 30, 2020
c4fc076
Auto merge of #6269 - camsteffen:map-clone-deref, r=ebroto
bors Nov 11, 2020
a1cf2d3
Added a lint as suggested in 6010 which recommends using `contains()`
rsulli55 Oct 6, 2020
431fcbc
Moved the tests for lint `search_is_some` to new files
rsulli55 Oct 17, 2020
55dc822
Ran `tests/ui/update-all-references.sh" and `cargo dev fmt`
rsulli55 Oct 17, 2020
e9612f3
Remove `to_string` on msg
rsulli55 Oct 26, 2020
fb74b48
Remove borrow
rsulli55 Oct 26, 2020
ee1b959
Added period back to lint `search_is_some` and ran
rsulli55 Oct 31, 2020
fd30313
Cleaned up message and suggestion for `lint_search_is_some`
rsulli55 Nov 7, 2020
56d252c
Update clippy_lints/src/methods/mod.rs
rsulli55 Nov 11, 2020
5c1c50e
Change variable named `foo` and rerun `update-all-references`
rsulli55 Nov 11, 2020
f92f8d0
Fix typo in comment
eltociear Nov 11, 2020
5f310d9
Implement destructuring assignment for structs and slices
fanzier Nov 7, 2020
5f64867
Fix suggestion in `manual_range_contains` when using float
giraffate Nov 11, 2020
92ece84
Auto merge of #78782 - petrochenkov:nodoctok, r=Aaron1011
bors Nov 12, 2020
bd13a35
Auto merge of #6325 - flip1995:rustup, r=flip1995
bors Nov 12, 2020
3a648ff
Rollup merge of #78836 - fanzier:struct-and-slice-destructuring, r=pe…
m-ou-se Nov 12, 2020
c6b74df
Fix dogfood test
giraffate Nov 13, 2020
cf7b4b0
Auto merge of #6329 - giraffate:sync-from-rust, r=matthiaskrgr
bors Nov 13, 2020
7987f39
update clippy test ouput
vn-ki Nov 13, 2020
408b615
Auto merge of #6320 - giraffate:fix_suggestion_in_manual_range_contai…
bors Nov 14, 2020
864e554
Add underscore expressions for destructuring assignments
fanzier Nov 11, 2020
0c7a48c
Auto merge of #78809 - vn-ki:fix-issue-76064, r=oli-obk
bors Nov 14, 2020
cbb6b1c
Introduce `TypeVisitor::BreakTy`
LeSeulArtichaut Nov 5, 2020
1b55cc7
Set the default `BreakTy` to `!`
LeSeulArtichaut Nov 14, 2020
27a1572
Rollup merge of #79016 - fanzier:underscore-expressions, r=petrochenkov
jonas-schievink Nov 15, 2020
db04641
Auto merge of #6334 - flip1995:rustup, r=flip1995
bors Nov 15, 2020
0e80341
Add `rustfmt::skip` as a work around
giraffate Nov 16, 2020
df3bb58
Auto merge of #6336 - giraffate:sync-from-rust, r=flip1995
bors Nov 16, 2020
ad4f829
Auto merge of #6119 - rsulli55:find_is_some_on_strs, r=flip1995
bors Nov 16, 2020
3567ea5
clippy: fold by value
lcnr Oct 24, 2020
5b8f2b6
Remove `expect()` calls to avoid ICEs in `deref_addrof` lint
ThibsG Nov 16, 2020
a467c51
Auto merge of #78779 - LeSeulArtichaut:ty-visitor-return, r=oli-obk
bors Nov 17, 2020
a7ac441
Add new lint to detect unnecessarily wrapped value
hkmatsumoto Sep 19, 2020
750c118
Add suggestion on type signatures
hkmatsumoto Sep 20, 2020
0335b8d
Fix lint example
hkmatsumoto Sep 20, 2020
0e9d227
Add test cases
hkmatsumoto Sep 20, 2020
ebdd4e2
Refactor code according to reivews
hkmatsumoto Sep 22, 2020
6a62390
Optout rustfix test
hkmatsumoto Sep 22, 2020
3ed8902
Fix typo
hkmatsumoto Sep 22, 2020
c775856
Call `diag.multipart_suggestion` instead
hkmatsumoto Sep 22, 2020
a433d46
Run rustfmt
hkmatsumoto Sep 22, 2020
cdb72df
Split lint suggestion into two
hkmatsumoto Sep 26, 2020
6b55f3f
Add test case
hkmatsumoto Sep 26, 2020
df0d565
Move `find_all_ret_expressions` into `utils`
hkmatsumoto Oct 2, 2020
eec7f5c
Update clippy_lints/src/unnecessary_wrap.rs
hkmatsumoto Oct 12, 2020
1bdac87
Improve lint message
hkmatsumoto Oct 12, 2020
8392bc7
Run `cargo dev fmt`
hkmatsumoto Oct 12, 2020
2f85aa7
Make lint skip closures
hkmatsumoto Oct 18, 2020
12474c6
Add support for methods
hkmatsumoto Oct 18, 2020
c5447eb
Make lint skip macros
hkmatsumoto Oct 18, 2020
c7692cf
Skip function with no exprs contained
hkmatsumoto Oct 18, 2020
30632fb
Allow this lint on lint tests
hkmatsumoto Oct 18, 2020
e998d61
Downgrade applicability to MaybeIncorrect
hkmatsumoto Oct 18, 2020
9d96311
Remove wildcard use
hkmatsumoto Oct 18, 2020
532d205
Skip functions in PartialOrd
hkmatsumoto Oct 18, 2020
bf46f78
Fix clippy error
hkmatsumoto Oct 18, 2020
86331a4
Update stderr files
hkmatsumoto Nov 2, 2020
4c8d248
Update stderr files
hkmatsumoto Nov 14, 2020
4e5c02e
Ignore trait implementations
hkmatsumoto Nov 14, 2020
1f577c0
Fix embarrassing grammatical error
hkmatsumoto Nov 14, 2020
c7445d7
Pluralize lint name
hkmatsumoto Nov 17, 2020
bf2d31d
Run cargo dev fmt
flip1995 Nov 17, 2020
a8cafc6
Auto merge of #6338 - flip1995:rustup, r=flip1995
bors Nov 17, 2020
5464cbe
Auto merge of #6337 - ThibsG:FixIce6332, r=Manishearth
bors Nov 17, 2020
4e4c4fb
Fix handling of panic calls
camelid Nov 17, 2020
44d9445
Auto merge of #6070 - matsujika:unnecessary_wrap, r=flip1995
bors Nov 17, 2020
0502ac2
Improve doc about `map_clone`
giraffate Nov 17, 2020
8c2e2fd
Auto merge of #6340 - giraffate:improve_doc_for_map_clone, r=Manishearth
bors Nov 18, 2020
6494bd0
Revert "Add `rustfmt::skip` as a work around"
giraffate Nov 18, 2020
577ebc8
Rollup merge of #79145 - camelid:clippy-fix-panics, r=flip1995
m-ou-se Nov 18, 2020
b2aefb8
Auto merge of #6345 - giraffate:follow_up_of_rustup, r=flip1995
bors Nov 19, 2020
4bf58bd
Add CHANGELOG for 1.48
flip1995 Nov 19, 2020
a98acdb
Fix trailing whitespaces in CHANGELOG file
flip1995 Nov 19, 2020
e9afdf0
Improve changlog update documentation
flip1995 Nov 19, 2020
78faaef
Remove the clippy::panic-params lint.
m-ou-se Nov 19, 2020
113c147
Clippy: Match on assert!() expansions without an inner block.
m-ou-se Nov 19, 2020
dd4e471
Properly deprecate panic_params lint
flip1995 Nov 20, 2020
5ee0a40
Fix dogfood errors
flip1995 Nov 20, 2020
8325d48
Auto merge of #6351 - flip1995:rustup, r=flip1995
bors Nov 20, 2020
70ffebf
Auto merge of #6347 - flip1995:changelog, r=Manishearth
bors Nov 20, 2020
8b21241
Revert "Convert the await holding lints to correctness"
Nov 20, 2020
0402c6a
Auto merge of #6354 - Daniel-B-Smith:refcell_ref_await, r=flip1995
bors Nov 20, 2020
9b910e1
a typo
Nov 22, 2020
e30bb76
update
Nov 22, 2020
4284ec3
Auto merge of #6364 - o752d:master, r=flip1995
bors Nov 22, 2020
831aa96
Auto merge of #6363 - o752d:patch-2, r=flip1995
bors Nov 22, 2020
034244f
Small grammar, punctuation, and code style improvements to docs
carols10cents Nov 21, 2020
445466e
Apply suggestions from code review to change "that" to "which"
carols10cents Nov 22, 2020
3e7c6de
Auto merge of #6361 - integer32llc:doc-style, r=carols10cents
bors Nov 22, 2020
dfac9be
Merge commit '3e7c6dec244539970b593824334876f8b6ed0b18' into clippyup
flip1995 Nov 23, 2020
99b9459
Fix ICE in utils::implements_trait
flip1995 Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix embarrassing grammatical error
  • Loading branch information
@hkmatsumoto
hkmatsumoto committed Nov 17, 2020
commit 1f577c030049d974b7982f46e90d2bf96e665ea1
2 changes: 1 addition & 1 deletion tests/ui/unnecessary_wrap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ trait B {
}
}

impl A for B {
impl B for A {
// trait impls are not linted
fn func13() -> Option<i32> {
Some(0)
Expand Down