MIR Body: Cache result of is_cyclic call

[bugadani]

No description provided.

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[bugadani]

Well since I've basically copied the predecessor cache, I've also copied it's testing strategy - i.e., none. I'll try to think about a way to avoid having to eagerly invalidate the caches.

[JohnCSimon]

@bugadani - ping from triage - can you post your status on this PR? I've assigned it S-waiting-on-author because it looks like your PR still needs more work.

[bugadani]

@JohnCSimon I considered this PR "done", We could do a perf run to see if this change has any practical benefits, but otherwise I don't intend to make more modifications.

looks like your PR still needs more work.

Do you have anything particular in mind?

[crlf0710]

Switching back to S-waiting-on-review.

[Dylan-DPC-zz]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

[bors]

⌛ Trying commit 039f54a4884803f65c1af5b6a8d7b9b5faba98bb with merge 7bf4a51615b645428dbc325d087b4e41d0ae0cca...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_ast_lowering v0.0.0 (/checkout/compiler/rustc_ast_lowering)
   Compiling chalk-engine v0.36.0
   Compiling rustc_middle v0.0.0 (/checkout/compiler/rustc_middle)
   Compiling rustc_ast_passes v0.0.0 (/checkout/compiler/rustc_ast_passes)
error: cannot find macro `CloneTypeFoldableAndLiftImpls` in this scope
  --> compiler/rustc_middle/src/mir/graph_cyclic_cache.rs:60:1
   |
60 | CloneTypeFoldableAndLiftImpls! {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a macro with a similar name exists: `TrivialTypeFoldableAndLiftImpls`
  ::: compiler/rustc_middle/src/macros.rs:83:1
   |
   |
83 | macro_rules! TrivialTypeFoldableAndLiftImpls {
   | -------------------------------------------- similarly named macro `TrivialTypeFoldableAndLiftImpls` defined here
   Compiling rustc_expand v0.0.0 (/checkout/compiler/rustc_expand)
   Compiling rustc_builtin_macros v0.0.0 (/checkout/compiler/rustc_builtin_macros)
   Compiling rustc_builtin_macros v0.0.0 (/checkout/compiler/rustc_builtin_macros)
error[E0277]: the trait bound `GraphIsCyclicCache: ty::fold::TypeFoldable<'_>` is not satisfied
    |
    |
148 |   #[derive(Clone, TyEncodable, TyDecodable, Debug, HashStable, TypeFoldable)]
    |                                                                |
    |                                                                |
    |                                                                the trait `ty::fold::TypeFoldable<'_>` is not implemented for `GraphIsCyclicCache`
    | 
   ::: compiler/rustc_middle/src/ty/fold.rs:48:5
    |
    |
48  |       fn fold_with<F: TypeFolder<'tcx>>(self, folder: &mut F) -> Self {
    |       --------------------------------------------------------------- required by `ty::fold::TypeFoldable::fold_with`
   ::: /cargo/registry/src/github.com-1ecc6299db9ec823/synstructure-0.12.4/src/macros.rs:94:9
    |
    |
94  | /         pub fn $derives(
95  | |             i: $crate::macros::TokenStream
96  | |         ) -> $crate::macros::TokenStream {
    | |________________________________________- in this expansion of `#[derive(TypeFoldable)]`

error[E0277]: the trait bound `GraphIsCyclicCache: ty::fold::TypeFoldable<'_>` is not satisfied
    |
    |
148 |   #[derive(Clone, TyEncodable, TyDecodable, Debug, HashStable, TypeFoldable)]
    |                                                                |
    |                                                                |
    |                                                                the trait `ty::fold::TypeFoldable<'_>` is not implemented for `GraphIsCyclicCache`
    | 
   ::: compiler/rustc_middle/src/ty/fold.rs:53:5
    |
    |
53  |       fn visit_with<V: TypeVisitor<'tcx>>(&self, visitor: &mut V) -> ControlFlow<V::BreakTy> {
    |       -------------------------------------------------------------------------------------- required by `ty::fold::TypeFoldable::visit_with`
   ::: /cargo/registry/src/github.com-1ecc6299db9ec823/synstructure-0.12.4/src/macros.rs:94:9
    |
    |
94  | /         pub fn $derives(
95  | |             i: $crate::macros::TokenStream
96  | |         ) -> $crate::macros::TokenStream {
    | |________________________________________- in this expansion of `#[derive(TypeFoldable)]`
error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0277`.
error: could not compile `rustc_middle`
error: could not compile `rustc_middle`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--features" "jemalloc llvm max_level_info" "--manifest-path" "/checkout/compiler/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu --include-default-paths src/tools/build-manifest
Build completed unsuccessfully in 0:09:42

[jyn514]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

[bors]

⌛ Trying commit 119879c with merge 08b66ce00bc45651e97c490b2aab2bd5dad9d9b1...

[bors]

☀️ Try build successful - checks-actions
Build commit: 08b66ce00bc45651e97c490b2aab2bd5dad9d9b1 (08b66ce00bc45651e97c490b2aab2bd5dad9d9b1)

[rust-timer]

Queued 08b66ce00bc45651e97c490b2aab2bd5dad9d9b1 with parent 2ad5292, future comparison URL.

@rustbot label: +S-waiting-on-perf

[rust-timer]

Finished benchmarking try commit (08b66ce00bc45651e97c490b2aab2bd5dad9d9b1): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[jyn514]

Up to -.8% instruction counts on many-assoc-items. No regressions :)

[oli-obk]

@bors r+

Thanks! Once we get a third cache we should start thinking about a more generic concept for caches, but at this stage, copying seems absolutely right to me.

[bors]

📌 Commit 119879c has been approved by oli-obk

[oli-obk]

r? @oli-obk

[bors]

⌛ Testing commit 119879c with merge 76aca66...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 76aca66 to master...