Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc: 0.2.79 -> 0.2.80 #78378

Closed
wants to merge 1 commit into from
Closed

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Oct 25, 2020

This PR bumps the version of the libc crate from 0.2.79 to 0.2.80 in order to hopefully fix a build failure when building the standard library for the tier 3 x86_64-unknown-dragonfly target.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2020
@nagisa
Copy link
Member Author

nagisa commented Oct 25, 2020

cc @JohnTitor

Cargo.lock Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

I generally ask that such PRs also bump the libc dep in a Cargo.toml somewhere in the workspace, so we don't accidentally regress in a future PR when rebasing across this change (I've done it before myself, and only noticed when looking at the diff, which for larger Cargo.lock changes is a bit untenable). r=me with that done.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2020
@nagisa
Copy link
Member Author

nagisa commented Oct 26, 2020

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Oct 26, 2020

📌 Commit 00abef1 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2020
@jonas-schievink
Copy link
Contributor

@bors rollup=iffy r- failed in #78451 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 27, 2020
@crlf0710
Copy link
Member

Triage: What's the status of this?

@nagisa
Copy link
Member Author

nagisa commented Nov 13, 2020

There are outstanding issues that need to be resolved before this can land. It still needs to land some day, though, but it likely will be a bump to a different libc version.

@nagisa nagisa closed this Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants