Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #78019

Closed
wants to merge 28 commits into from

Commits on Oct 11, 2020

  1. Don't link to nightly primitives on stable channel

    I am not sure how to test this.
    jyn514 committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    54bf8a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. BTreeMap: refactor Entry out of map.rs into its own file

    btree/map.rs is approaching the 3000 line mark, splitting out the entry
    code buys about 500 lines of headroom
    Jacob Hughes committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    4b96049 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e4028f View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Configuration menu
    Copy the full SHA
    2e832c9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3649620 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8c0c7ec View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Configuration menu
    Copy the full SHA
    28af355 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6fdd98d View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Configuration menu
    Copy the full SHA
    e833cd3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7272ea View commit details
    Browse the repository at this point in the history
  3. resolve: suggest variants with placeholders

    This commit improves the diagnostic modified in rust-lang#77341 to
    suggest not only those variants which do not have fields, but those with
    fields (by suggesting with placeholders).
    
    Signed-off-by: David Wood <david@davidtw.co>
    davidtwco committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    adf31e9 View commit details
    Browse the repository at this point in the history
  4. resolve: improve "try using tuple struct" message

    This commit improves the tuple struct case added in rust-lang#77341
    so that the context is mentioned in more of the message.
    
    Signed-off-by: David Wood <david@davidtw.co>
    davidtwco committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    f897162 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1588e34 View commit details
    Browse the repository at this point in the history
  6. Bump backtrace-rs

    This pulls in rust-lang/backtrace-rs#376, which
    fixes Miri support for `std::backtrace::Backtrace`.
    Aaron1011 committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    865c30d View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Deny broken intra-doc links in linkchecker

    Since rustdoc isn't warning about these links, check for them manually.
    jyn514 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    65835d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b221819 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a32e79 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    defcd7f View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#77547 - RalfJung:stable-union-drop, r=matth…

    …ewjasper
    
    stabilize union with 'ManuallyDrop' fields and 'impl Drop for Union'
    
    As [discussed by @SimonSapin and @withoutboats](rust-lang#55149 (comment)), this PR proposes to stabilize parts of the `untagged_union` feature gate:
    
    * It will be possible to have a union with field type `ManuallyDrop<T>` for any `T`.
    * While at it I propose we also stabilize `impl Drop for Union`; to my knowledge, there are no open concerns around this feature.
    
    In the RFC discussion, we also talked about allowing `&mut T` as another non-`Copy` non-dropping type, but that felt to me like an overly specific exception so I figured we'd wait if there is actually any use for such a special case.
    
    Some things remain unstable and still require the `untagged_union` feature gate:
    * Union with fields that do not drop, are not `Copy`, and are not `ManuallyDrop<_>`. The reason to not stabilize this is to avoid semver concerns around libraries adding `Drop` implementations later. (This is already not fully semver compatible as, to my knowledge, the borrow checker will exploit the non-dropping nature of any type, but it seems prudent to avoid further increasing the amount of trouble adding an `impl Drop` can cause.)
    
    Due to this, quite a few tests still need the `untagged_union` feature, but I think the ones where I could remove the feature flag provide good test coverage for the stable part.
    
    Cc @rust-lang/lang
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    f0b4427 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#77827 - jyn514:stable-primitives, r=Guillau…

    …meGomez
    
    Don't link to nightly primitives on stable channel
    
    I am not sure how to test this.
    
    Closes rust-lang#77775
    
    r? @GuillaumeGomez
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    d15f263 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#77851 - exrook:split-btreemap, r=dtolnay

    BTreeMap: refactor Entry out of map.rs into its own file
    
    btree/map.rs is approaching the 3000 line mark, splitting out the entry
    code buys about 500 lines of headroom.
    
    I've created this PR because the changes I've made in rust-lang#77438 will push `map.rs` over the 3000 line limit and cause tidy to complain.
    
    I picked `Entry` to factor out because it feels less tightly coupled to the rest of `BTreeMap` than the various iterator implementations.
    
    Related: rust-lang#60302
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    ffbecf5 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#77855 - davidtwco:pr-77341-follow-up-non-co…

    …nstructable-variants, r=estebank
    
    resolve: further improvements to "try using the enum's variant" diagnostic
    
    Follow-up on rust-lang#77341 (comment).
    
    This PR improves the diagnostic modified in rust-lang#77341 to suggest not only those variants which do not have fields, but those with fields (by suggesting with placeholders). In addition, the wording of the tuple-variant-only case is improved slightly.
    
    I've not made further changes to the tuple-variant-only case (e.g. to only suggest variants with the correct number of fields) because I don't think I have enough information to do so reliably (e.g. in the case where there is an attempt to construct a tuple variant, I have no information on how many fields were provided; and in the case of pattern matching, I only have a slice of spans and would need to check for things like `..` in those spans, which doesn't seem worth it).
    
    r? @estebank
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    4969437 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#77856 - GuillaumeGomez:automatic-links-lint…

    …, r=jyn514
    
    Add automatic_links lint
    
    Fixes rust-lang#77501.
    
    r? @jyn514
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    6488861 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#77900 - Thomasdezeeuw:fdatasync, r=dtolnay

    Use fdatasync for File::sync_data on more OSes
    
    Add support for the following OSes:
     * Android
     * FreeBSD: https://www.freebsd.org/cgi/man.cgi?query=fdatasync&sektion=2
     * OpenBSD: https://man.openbsd.org/OpenBSD-5.8/fsync.2
     * NetBSD: https://man.netbsd.org/fdatasync.2
     * illumos: https://illumos.org/man/3c/fdatasync
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    9f0229e View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#77932 - ssomers:btree_cleanup_gdb, r=Mark-S…

    …imulacrum
    
    BTreeMap: improve gdb introspection of BTreeMap with ZST keys or values
    
    I accidentally pushed an earlier revision in rust-lang#77788: it changes the index of tuples for BTreeSet from ""[{}]".format(i) to "key{}".format(i). Which doesn't seem to make the slightest difference on my linux box nor on CI. In fact, gdb doesn't make any distinction between "key{}" and "val{}" for a BTreeMap either, leading to confusing output if you test more. But easy to improve.
    
    r? @Mark-Simulacrum
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    181deb4 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#77971 - jyn514:broken-intra-doc-links, r=ma…

    …rk-simulacrum
    
    Deny broken intra-doc links in linkchecker
    
    Since rustdoc isn't warning about these links, check for them manually.
    
    This also fixes the broken links that popped up from the lint.
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    5398a4a View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#77985 - cuviper:systemz-agr-clobbers-cc, r=…

    …nikic
    
    llvm: backport SystemZ fix for AGR clobbers
    
    Fixes rust-lang#77382.
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    a934284 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#77991 - Aaron1011:bump-backtrace-again, r=M…

    …ark-Simulacrum
    
    Bump backtrace-rs
    
    This pulls in rust-lang/backtrace-rs#376, which
    fixes Miri support for `std::backtrace::Backtrace`.
    Dylan-DPC authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    236caf2 View commit details
    Browse the repository at this point in the history