Skip to content

Change AllocRef::by_ref to take &self instead of &mut self #77289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2020
Merged

Change AllocRef::by_ref to take &self instead of &mut self #77289

merged 1 commit into from
Sep 30, 2020

Conversation

@TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Sep 28, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2020
@Amanieu
Copy link
Member

Amanieu commented Sep 28, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 28, 2020

📌 Commit c22d896 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#77289 - TimDiekmann:alloc-ref-by-ref, r=Ama…
a063e5e 
…nieu

Change `AllocRef::by_ref` to take `&self` instead of `&mut self`

r? @Amanieu
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 28, 2020
Closed
@bors
Copy link
Collaborator

bors commented Sep 29, 2020

⌛ Testing commit c22d896 with merge 0d97f7a...

@bors
Copy link
Collaborator

bors commented Sep 30, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Amanieu
Pushing 0d97f7a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 30, 2020
@bors bors merged commit 0d97f7a into rust-lang:master Sep 30, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 30, 2020
@TimDiekmann TimDiekmann mentioned this pull request Sep 30, 2020
Merged
@TimDiekmann TimDiekmann deleted the alloc-ref-by-ref branch September 30, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

5 participants

@TimDiekmann @Amanieu @bors @rust-highfive @rustbot