Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn for #[unstable] on trait impls when it has no effect. #76538

Merged
merged 8 commits into from
Sep 12, 2020
Merged

Warn for #[unstable] on trait impls when it has no effect. #76538

merged 8 commits into from
Sep 12, 2020

Commits on Sep 11, 2020

  1. Warn for #[unstable] on trait impls when it has no effect.

    @m-ou-se
    m-ou-se committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    1854f8b View commit details
    Browse the repository at this point in the history

  2. Turn useless #[unstable] attributes into errors.

    @m-ou-se
    m-ou-se committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    e5c645f View commit details
    Browse the repository at this point in the history

  3. Mark RefUnwindSafe impls for stable atomic types as stable. 

    These impls were effectively stable. #[unstable] had no effect here,
since both RefUnwindSafe and these types were already stable.

These effectively became stable as soon as the types became stable,
which was in 1.34.0.
    @m-ou-se
    m-ou-se committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    f6fbf66 View commit details
    Browse the repository at this point in the history

  4. Mark Error impl for LayoutErr as stable. 

    This impl was effectively stable. #[unstable] had no effect here,
since both Error and LayoutErr were already stable.

This effectively became stable as soon as LayoutErr became stable, which
was in 1.28.0.
    @m-ou-se
    m-ou-se committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    cf8e5d1 View commit details
    Browse the repository at this point in the history

  5. Turn unstable trait impl error into a lint, so it can be disabled.

    @m-ou-se
    m-ou-se committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    89fb34f View commit details
    Browse the repository at this point in the history

  6. Allow unstable From impl for [Raw]Waker.

    @m-ou-se
    m-ou-se committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    471fb62 View commit details
    Browse the repository at this point in the history

  7. Add test for unstable trait impl lint.

    @m-ou-se
    m-ou-se committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    1c1bfba View commit details
    Browse the repository at this point in the history

  8. Improve ineffective_unstable_trait_impl error message.

    @m-ou-se
    m-ou-se committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    14cc177 View commit details
    Browse the repository at this point in the history