Skip to content

do not inline black_box when building for Miri #76434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2020
Merged

do not inline black_box when building for Miri #76434

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
caeb554
do not inline black_box when building for Miri
RalfJung Sep 7, 2020
4b5cd54
use black_box instead of local optimziation barriers in const tests w…
RalfJung Sep 7, 2020
47668ed
Separate feature flags
RalfJung Sep 7, 2020
284b169
add missing feature flag
RalfJung Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
do not inline black_box when building for Miri
  • Loading branch information
@RalfJung
RalfJung committed Sep 7, 2020
commit caeb5544ecd9dba4d67b68b8c1b32d8132c6d5f2
3 changes: 2 additions & 1 deletion library/core/src/hint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ pub fn spin_loop() {
/// Note however, that `black_box` is only (and can only be) provided on a "best-effort" basis. The
/// extent to which it can block optimisations may vary depending upon the platform and code-gen
/// backend used. Programs cannot rely on `black_box` for *correctness* in any way.
#[inline]
#[cfg_attr(not(miri), inline)]
#[cfg_attr(miri, inline(never))]
#[unstable(feature = "test", issue = "50297")]
#[allow(unreachable_code)] // this makes #[cfg] a bit easier below.
pub fn black_box<T>(dummy: T) -> T {
Expand Down