Skip to content

Fix -Clinker-plugin-lto with opt-levels s and z #75956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2020
Merged

Fix -Clinker-plugin-lto with opt-levels s and z #75956

merged 2 commits into from
Oct 12, 2020

Conversation

jonas-schievink
Copy link
Contributor

Pass s and z as -plugin-opt=O2 to the linker. This is what -Os and -Oz correspond to, apparently.

Fixes #75940

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2020
@bors

This comment has been minimized.

Sign in to view
tmiasko
tmiasko approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@tmiasko tmiasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This matches clang behaviour. It is also how clang interprets z and s as an optimization level more generally.

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2020
@jonas-schievink
Copy link
Contributor Author

@bors r=tmiasko

@bors
Copy link
Collaborator

bors commented Oct 11, 2020

📌 Commit afe84b6fae3495cf7283670ead91d21eb3dae66d has been approved by tmiasko

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2020
@bors
Copy link
Collaborator

bors commented Oct 11, 2020

⌛ Testing commit afe84b6fae3495cf7283670ead91d21eb3dae66d with merge a83da56c32160c51ba51383dbe860643955594b1...

@bors
Copy link
Collaborator

bors commented Oct 11, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 11, 2020
@jonas-schievink
Copy link
Contributor Author

@bors r=tmiasko

@bors
Copy link
Collaborator

bors commented Oct 11, 2020

📌 Commit 32cf035 has been approved by tmiasko

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2020
@bors
Copy link
Collaborator

bors commented Oct 12, 2020

⌛ Testing commit 32cf035 with merge 62cbe81...

@bors
Copy link
Collaborator

bors commented Oct 12, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: tmiasko
Pushing 62cbe81 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 12, 2020
@bors bors merged commit 62cbe81 into rust-lang:master Oct 12, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmiasko tmiasko tmiasko approved these changes

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

-Clinker-plugin-lto breaks with -Copt-level=s/z
7 participants
@jonas-schievink @rust-highfive @bors @tmiasko @crlf0710 @estebank @rustbot