polymorphize GlobalAlloc::Function #74623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcnr
force-pushed
the
polymorphize-functions
branch
from
d843e09
to
4d28763
Compare
davidtwco
reviewed
Jul 22, 2020
davidtwco
approved these changes
Jul 22, 2020
|
☔ The latest upstream changes (presumably #73270) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
lcnr
force-pushed
the
polymorphize-functions
branch
from
506655b
to
40b6bcc
Compare
|
@bors r+ rollup=never (I know it's small, but we want to be able to bisect anything polymorphization-related) |
|
📌 Commit 40b6bcc has been approved by |
bors
added
S-waiting-on-bors
|
Considering that polymorphization is currently disabled we don't need rollup=never here @bors rollup=always |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 24, 2020
Rollup of 12 pull requests Successful merges: - rust-lang#74361 (Improve doc theme logo display) - rust-lang#74504 (Add right border bar to Dark and Light theme) - rust-lang#74572 (Internally unify rustc_deprecated and deprecated) - rust-lang#74601 (Clean up E0724 explanation) - rust-lang#74623 (polymorphize GlobalAlloc::Function) - rust-lang#74665 (Don't ICE on unconstrained anonymous lifetimes inside associated types.) - rust-lang#74666 (More BTreeMap test cases, some exposing undefined behaviour) - rust-lang#74669 (Fix typo) - rust-lang#74677 (Remove needless unsafety from BTreeMap::drain_filter) - rust-lang#74680 (Add missing backticks in diagnostics note) - rust-lang#74694 (Clean up E0727 explanation) - rust-lang#74703 (Fix ICE while building MIR with type errors) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this sadly does not change #74614
r? @eddyb