Fixes #7377 #7443
Merged
Fixes #7377 #7443
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because of forced update, previous comment is gone. Sorry. I added a test case which I forgot to add. I tried to change @str/@struct_field to &str/&struct_field, but because of lifetime issue, there is no easy way to change it. |
| @@ -3886,6 +3886,27 @@ impl Resolver { | |||
| generics: &Generics, | |||
| fields: &[@struct_field], | |||
| visitor: ResolveVisitor) { | |||
| let mut ident_str_map = HashMap::new::<@str, @struct_field>(); | |||
There was a problem hiding this comment.
Can this be HashMap::new::<ast::ident, @struct_field>(), to avoid the .str_of call? (If two strings are equal, then their idents are equal too.)
bors
added a commit
that referenced
this pull request
Jul 1, 2013
Check if there is duplicated field names in struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if there is duplicated field names in struct.