Skip to content

Rollup of 10 pull requests #74243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f8eb81b
Modify type names on MSVC to make tuples .natvis compatible.
MaulingMonkey Jun 25, 2020
24a728a
debuginfo: Define int/float types in terms of MSVC-recognized types.
MaulingMonkey Jun 25, 2020
825eb47
Add support for storing code model to LLVM module IR
kubo39 Jul 3, 2020
b99a08a
Remove code-model=tiny from module IR test
kubo39 Jul 3, 2020
4a89c9f
Remove duplicated to_llvm_code_model function
kubo39 Jul 3, 2020
67a5e2b
Fix for reviews
kubo39 Jul 4, 2020
5c24a94
Remove target flag from code model test
kubo39 Jul 5, 2020
59f979f
Fix cross-compilation of LLVM to aarch64 Windows targets
arlosi Jul 2, 2020
7fb421b
linker: illumos ld does not support --eh-frame-hdr
jclulow Jul 8, 2020
520fb92
Reword incorrect `self` token suggestion
estebank Jul 9, 2020
6864546
Add a help to use `in_band_lifetimes` in nightly
JohnTitor Jul 8, 2020
a9b6476
Tweak wording
JohnTitor Jul 9, 2020
1fb0ed0
Minor refactor for rustc_resolve diagnostics match
pickfire Jul 10, 2020
dd872be
Stabilize `transmute` in constants and statics but not const fn
oli-obk Aug 30, 2019
b929f72
Fix try_print_visible_def_path_recur for opt_def_id usage
da-x Jul 11, 2020
6bda2e8
update miri
RalfJung Jul 11, 2020
f5de23b
Add the test case mentioned in #74236
da-x Jul 11, 2020
1f4e578
Rollup merge of #72920 - oli-obk:const_transmute, r=RalfJung
Manishearth Jul 11, 2020
7457f48
Rollup merge of #73715 - MaulingMonkey:pr-natvis-tuples, r=Amanieu
Manishearth Jul 11, 2020
03032e8
Rollup merge of #74002 - kubo39:set-code-model, r=nagisa
Manishearth Jul 11, 2020
b68d0e6
Rollup merge of #74116 - arlosi:aarch64build, r=pietroalbini
Manishearth Jul 11, 2020
22b8ad3
Rollup merge of #74167 - jclulow:illumos-linker-eh-frame-hdr-fix, r=p…
Manishearth Jul 11, 2020
dce3fb7
Rollup merge of #74168 - JohnTitor:help-for-in-band-lifetimes, r=petr…
Manishearth Jul 11, 2020
1bd03b2
Rollup merge of #74197 - estebank:self-sugg, r=petrochenkov
Manishearth Jul 11, 2020
2e95d26
Rollup merge of #74213 - pickfire:patch-1, r=jonas-schievink
Manishearth Jul 11, 2020
89c75bd
Rollup merge of #74240 - da-x:fix-74081, r=Manishearth
Manishearth Jul 11, 2020
d6c4c9e
Rollup merge of #74241 - RalfJung:miri, r=RalfJung
Manishearth Jul 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/librustc_middle/ty/print/pretty.rs
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ pub trait PrettyPrinter<'tcx>:
.tcx()
.item_children(visible_parent)
.iter()
.find(|child| child.res.def_id() == def_id)
.find(|child| child.res.opt_def_id() == Some(def_id))
.map(|child| child.ident.name);
if let Some(reexport) = reexport {
*name = reexport;
Expand Down
8 changes: 8 additions & 0 deletions src/test/ui/issues/issue-74236/auxiliary/dep.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// edition:2018

mod private { pub struct Pub; }

// Reexport built-in attribute without a DefId (requires Rust 2018).
pub use cfg_attr as attr;
// This export needs to be after the built-in attribute to trigger the bug.
pub use private::Pub as Renamed;
9 changes: 9 additions & 0 deletions src/test/ui/issues/issue-74236/main.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// edition:2018
// aux-build:dep.rs
// compile-flags:--extern dep

fn main() {
// Trigger an error that will print the path of dep::private::Pub (as "dep::Renamed").
let () = dep::Renamed;
//~^ ERROR mismatched types
}
11 changes: 11 additions & 0 deletions src/test/ui/issues/issue-74236/main.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
error[E0308]: mismatched types
--> $DIR/main.rs:7:9
|
LL | let () = dep::Renamed;
| ^^ ------------ this expression has type `dep::Renamed`
| |
| expected struct `dep::Renamed`, found `()`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0308`.