Fix x.py test for librustc crates. #74153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Looks like as a result some tests are failing :/ r=me on the patch though. |
|
@bors r=Mark-Simulacrum |
|
📌 Commit 7238726 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=20 we should get tests running as quickly as possible to prevent further regressions |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 8, 2020
…r=Mark-Simulacrum Fix x.py test for librustc crates. rust-lang#73352 introduced a bug where `x.py test src/librustc_ast` would fail to actually run the tests. The issue is that `krate` and `all_krates` were changed to return relative paths. This caused the code to do a test of "relative_path ends with absolute path" which is always false. The solution is to swap that around. The change to `Crate` isn't necessary, it just simplifies the code and makes it uniform with `CrateLibrustc`.
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#73352 introduced a bug where
x.py test src/librustc_astwould fail to actually run the tests. The issue is thatkrateandall_krateswere changed to return relative paths. This caused the code to do a test of "relative_path ends with absolute path" which is always false. The solution is to swap that around.The change to
Crateisn't necessary, it just simplifies the code and makes it uniform withCrateLibrustc.