Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
318b8b6
Add hint for collect type
Mark-Simulacrum May 11, 2020
d4092ac
Merge pull request #5584 from Mark-Simulacrum/beta-next
flip1995 May 11, 2020
221c482
Stabilize str_strip feature
tesuji May 22, 2020
e820a03
iterate List by value
lcnr May 23, 2020
64a05f5
len_zero: skip ranges if feature `range_is_empty` is not enabled
ebroto May 27, 2020
7b49090
clippy_dev: add ra_setup
matthiaskrgr May 27, 2020
a0e9f9b
Merge commit '7ea7cd165ad6705603852771bf82cc2fd6560db5' into clippyup2
flip1995 May 28, 2020
b6c58f0
Temp fix: don't run cargo lint tests in rustc test suite
flip1995 May 28, 2020
28c690e
Rollup merge of #72466 - lzutao:stabilize_str-strip, r=dtolnay
Dylan-DPC May 29, 2020
fcc0e8f
Auto merge of #72671 - flip1995:clippyup, r=Xanewok
bors May 29, 2020
b92cc8a
add testcase that no longer ICEs
matthiaskrgr May 29, 2020
9fd8e10
Return early to avoid ICE
JohnTitor May 30, 2020
5faab87
new lint: vec_resize_to_zero
tnielens May 22, 2020
e6f5dd5
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 May 31, 2020
37381d3
Fix sync fallout
flip1995 May 31, 2020
5713574
Auto merge of #5665 - flip1995:rustup, r=matthiaskrgr
bors May 31, 2020
871f3ed
Auto merge of #5655 - matthiaskrgr:source_mod, r=flip1995
bors May 31, 2020
0fff522
Rollup merge of #5637 - montrivo:feature/vec_resize_to_zero, r=yaahc,…
flip1995 May 31, 2020
873c9fc
Rollup merge of #5656 - ebroto:len_zero_ranges, r=matthiaskrgr
flip1995 May 31, 2020
00c656d
Rollup merge of #5663 - matthiaskrgr:crash_test_3969, r=Manishearth
flip1995 May 31, 2020
0bcfae9
moved cast_ptr_alignment to pedantic and expanded documentation
djugei May 31, 2020
8b191b5
Auto merge of #5666 - flip1995:rollup-yjyvvbg, r=flip1995
bors May 31, 2020
18b5cee
ran update_lints
djugei May 31, 2020
8aa8f42
Auto merge of #5667 - djugei:master, r=flip1995
bors May 31, 2020
6122612
Increase cargo_metadata version to 0.9.1
May 31, 2020
0ab823c
Rework suggestion generation of `unit_arg` lint
flip1995 Aug 26, 2019
380d941
Adapt stderr and fixed files
flip1995 Aug 26, 2019
a1a1a4b
Use multiple span_suggestions instead of multipart_suggestion
flip1995 Aug 26, 2019
0f69caf
Rework suggestion generation and use multipart_suggestion again
flip1995 Feb 17, 2020
f9c325f
Suggest to remove the semicolon of the last stmt in a block
flip1995 Feb 17, 2020
4c9cefa
Move linting out in its own function
flip1995 Feb 18, 2020
6d15a14
Update test files
flip1995 Feb 17, 2020
a9cde3a
Don't suggest to move empty blocks
flip1995 May 31, 2020
77dd0ea
Add tests for empty blocks
flip1995 May 31, 2020
fcc3ed2
Auto merge of #5669 - mikerite:fix-cargo_metadata-0.9, r=phansch
bors May 31, 2020
9fdcb13
Auto merge of #4455 - flip1995:unit_arg_appl, r=phansch
bors May 31, 2020
14e9100
cargo-ui tests: check that <dir>/src exists before processing test
ebroto May 24, 2020
7e84351
Created lint
JarredAllen May 14, 2020
24847ea
Attempted start at sort_by_key_reverse lint
JarredAllen May 16, 2020
8590ab4
More progress towards sort_by_key_reverse lint
JarredAllen May 19, 2020
943cb94
Passes all tests now!
JarredAllen May 20, 2020
955a25e
Added negative test cases and ran cargo dev fmt
JarredAllen May 20, 2020
059e8ed
Detect also a non-reversed comparison
JarredAllen May 25, 2020
07886a9
Detect also when works
JarredAllen May 25, 2020
015ab9f
Renamed to
JarredAllen May 29, 2020
20cb512
Updated test cases and formatted
JarredAllen May 31, 2020
9f9877c
Auto merge of #5662 - ebroto:cargo_tests_invalid_crate, r=flip1995
bors May 31, 2020
32fde0b
New lint: iter_next_slice
esamudera May 25, 2020
7727c4a
CONTRIBUTING: explain how to use cargo dev ra-setup
matthiaskrgr May 28, 2020
6c008d7
Auto merge of #5661 - matthiaskrgr:explain_ra_setup, r=phansch
bors May 31, 2020
9a5baed
Implement suggestions from phansch
JarredAllen May 31, 2020
b89880a
Ran update_lints
JarredAllen May 31, 2020
6955420
Update changelog for stable:1.44 beta:1.45
ebroto May 31, 2020
bee0608
Auto merge of #5623 - JarredAllen:sort_by_key_reverse, r=phansch
bors Jun 1, 2020
ae0ce22
Add regression test for string_lit_as_bytes issue
phansch Jun 1, 2020
861b897
Add regression test for endless loop
phansch Jun 1, 2020
61587c9
Fix some code examples in doc
ThibsG May 27, 2020
262c9dc
Fix more code examples
ThibsG May 29, 2020
1933933
Give more corrected code examples in doc
ThibsG May 31, 2020
9893254
Add more corrected code for doc
ThibsG May 31, 2020
137a3b4
Corrected doc PR fixes
ThibsG Jun 1, 2020
9e89ba9
Add doc for checking if type defines certain method
ThibsG May 31, 2020
bfafb8e
Auto merge of #5673 - phansch:endless-loop, r=Manishearth
bors Jun 1, 2020
a44fa38
Update documentation on changelog updates
ebroto Jun 1, 2020
ea06c72
Call `skip_binder` or `no_bound_vars` before `self_ty`
ecstatic-morse May 23, 2020
f760d77
Auto merge of #5597 - esamudera:slice_iter_next, r=flip1995
bors Jun 2, 2020
5cb9ef3
Auto merge of #5664 - ThibsG:GiveCorrectedCode, r=flip1995
bors Jun 2, 2020
153ef1c
Auto merge of #5672 - phansch:regression-test-env, r=yaahc
bors Jun 2, 2020
fbf0b84
Make use of slice pattern
tesuji Jun 2, 2020
6c833df
Auto merge of #5678 - lzutao:slice, r=flip1995
bors Jun 2, 2020
2b79413
Rename the crates in source code
petrochenkov Jun 2, 2020
dcd4806
Apply suggestions from PR review
ebroto Jun 2, 2020
bd3fc11
Update fulldeps tests and clippy
petrochenkov Jun 2, 2020
b39fd5f
Fix false negative of checked_conversion lint
tesuji Jun 3, 2020
e2fdeec
Auto merge of #5677 - lzutao:checked_conv, r=matthiaskrgr
bors Jun 3, 2020
0c470b3
Bump to 1.46
Mark-Simulacrum Jun 3, 2020
7654125
match_wildcard_for_single_variants: remove empty line at start of lin…
matthiaskrgr Jun 4, 2020
a8957ac
Auto merge of #5681 - matthiaskrgr:empty_line, r=phansch
bors Jun 4, 2020
17bdc96
Merge remote-tracking branch 'upstream/beta' into backport_remerge
flip1995 Jun 5, 2020
f61840d
Auto merge of #5685 - flip1995:backport_remerge, r=flip1995
bors Jun 5, 2020
9ef15ae
Reorder sections of release documentation
flip1995 Jun 5, 2020
af9a094
Auto merge of #5686 - flip1995:release_doc, r=phansch
bors Jun 5, 2020
6fc9939
Auto merge of #5671 - ebroto:changelog_144_145, r=flip1995
bors Jun 5, 2020
6b9e2e9
Replace all remaining occurrences of submodule with subtree
flip1995 Jun 5, 2020
b16d101
Auto merge of #5687 - flip1995:release_doc, r=phansch
bors Jun 5, 2020
413713c
Add error info when cargo metadata fails to run
ebroto Jun 5, 2020
c325c12
Fix cargo ui tests when running inside rust repo
ebroto Jun 5, 2020
ea7066a
Auto merge of #5688 - ebroto:fix_cargo_tests_in_rustc, r=flip1995
bors Jun 5, 2020
b059c0a
Auto merge of #72927 - petrochenkov:rustc, r=Mark-Simulacrum
bors Jun 6, 2020
623faac
Cleanup: Use rustc's `same_types` instead of our `same_tys`
phansch Jun 6, 2020
e6f05ad
Auto merge of #5528 - phansch:same-tys, r=flip1995
bors Jun 6, 2020
5699672
Auto merge of #5674 - ThibsG:DocTypeDefinesMethod, r=yaahc,phansch,fl…
bors Jun 6, 2020
161474b
Rollup merge of #72508 - ecstatic-morse:poly-self-ty, r=nikomatsakis
RalfJung Jun 6, 2020
1a8a69d
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 Jun 7, 2020
5bdbc45
Rustup to rust-lang/rust#71796
flip1995 Jun 7, 2020
d9aa26a
Temporarily disable RLS integration test
flip1995 Jun 7, 2020
67ec96c
Auto merge of #5691 - flip1995:rustup, r=matthiaskrgr
bors Jun 7, 2020
dc13016
Make let_and_return a late lint pass
ebroto Jun 2, 2020
9c205d7
Rename let_and_return test for consistency with the lint name
ebroto Jun 6, 2020
dac8a3c
let_and_return: do not lint if last statement borrows
ebroto Jun 6, 2020
ebfc1da
reversed_empty_ranges: don't lint N..N except in for loop arg
ebroto Jun 7, 2020
7b6dc7b
add `unnested_or_patterns` lint
Centril Mar 19, 2020
a664ce7
Remove unnecessary lifetime parameter
ebroto Jun 7, 2020
78f158e
dogfood unnested_or_patterns
Centril Mar 28, 2020
d6136b9
split unnested_or_patterns test
Centril Mar 28, 2020
ecabed6
Apply self-review by Centril
flip1995 Jun 7, 2020
a9ca832
Fix rebase fallout
flip1995 Jun 7, 2020
08b84b3
Auto merge of #5378 - Centril:unnested-or-pats, r=flip1995,phansch
bors Jun 8, 2020
f947644
Auto merge of #5680 - ebroto:3792_let_return, r=Manishearth
bors Jun 8, 2020
ff0993c
Auto merge of #5692 - ebroto:5689_N_dotdot_N, r=yaahc
bors Jun 8, 2020
41c845e
Merge commit 'ff0993c5e9162ddaea78e83d0f0161e68bd4ea73' into clippy
tesuji Jun 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ran update_lints
  • Loading branch information
JarredAllen committed May 31, 2020
commit b89880a30ce4dd7887614f305a565b6779dc4825
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -1555,7 +1555,6 @@ Released 2018-09-13
[`single_match_else`]: https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else
[`skip_while_next`]: https://rust-lang.github.io/rust-clippy/master/index.html#skip_while_next
[`slow_vector_initialization`]: https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization
[`sort_by_key_reverse`]: https://rust-lang.github.io/rust-clippy/master/index.html#sort_by_key_reverse
[`str_to_string`]: https://rust-lang.github.io/rust-clippy/master/index.html#str_to_string
[`string_add`]: https://rust-lang.github.io/rust-clippy/master/index.html#string_add
[`string_add_assign`]: https://rust-lang.github.io/rust-clippy/master/index.html#string_add_assign
Expand Down Expand Up @@ -1602,6 +1601,7 @@ Released 2018-09-13
[`unnecessary_fold`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[`unnecessary_mut_passed`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[`unnecessary_operation`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[`unnecessary_sort_by`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[`unnecessary_unwrap`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[`unneeded_field_pattern`]: https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[`unneeded_wildcard_pattern`]: https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_wildcard_pattern
Expand Down
6 changes: 3 additions & 3 deletions clippy_lints/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
&shadow::SHADOW_UNRELATED,
&single_component_path_imports::SINGLE_COMPONENT_PATH_IMPORTS,
&slow_vector_initialization::SLOW_VECTOR_INITIALIZATION,
&unnecessary_sort_by::UNNECESSARY_SORT_BY,
&strings::STRING_ADD,
&strings::STRING_ADD_ASSIGN,
&strings::STRING_LIT_AS_BYTES,
Expand Down Expand Up @@ -835,6 +834,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
&unicode::ZERO_WIDTH_SPACE,
&unnamed_address::FN_ADDRESS_COMPARISONS,
&unnamed_address::VTABLE_ADDRESS_COMPARISONS,
&unnecessary_sort_by::UNNECESSARY_SORT_BY,
&unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
&unused_io_amount::UNUSED_IO_AMOUNT,
&unused_self::UNUSED_SELF,
Expand Down Expand Up @@ -1394,7 +1394,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
LintId::of(&serde_api::SERDE_API_MISUSE),
LintId::of(&single_component_path_imports::SINGLE_COMPONENT_PATH_IMPORTS),
LintId::of(&slow_vector_initialization::SLOW_VECTOR_INITIALIZATION),
LintId::of(&unnecessary_sort_by::UNNECESSARY_SORT_BY),
LintId::of(&strings::STRING_LIT_AS_BYTES),
LintId::of(&suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL),
LintId::of(&suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL),
Expand Down Expand Up @@ -1431,6 +1430,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
LintId::of(&unicode::ZERO_WIDTH_SPACE),
LintId::of(&unnamed_address::FN_ADDRESS_COMPARISONS),
LintId::of(&unnamed_address::VTABLE_ADDRESS_COMPARISONS),
LintId::of(&unnecessary_sort_by::UNNECESSARY_SORT_BY),
LintId::of(&unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME),
LintId::of(&unused_io_amount::UNUSED_IO_AMOUNT),
LintId::of(&unwrap::PANICKING_UNWRAP),
Expand Down Expand Up @@ -1596,7 +1596,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
LintId::of(&ranges::RANGE_ZIP_WITH_LEN),
LintId::of(&reference::DEREF_ADDROF),
LintId::of(&reference::REF_IN_DEREF),
LintId::of(&unnecessary_sort_by::UNNECESSARY_SORT_BY),
LintId::of(&swap::MANUAL_SWAP),
LintId::of(&temporary_assignment::TEMPORARY_ASSIGNMENT),
LintId::of(&transmute::CROSSPOINTER_TRANSMUTE),
Expand All @@ -1613,6 +1612,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
LintId::of(&types::UNIT_ARG),
LintId::of(&types::UNNECESSARY_CAST),
LintId::of(&types::VEC_BOX),
LintId::of(&unnecessary_sort_by::UNNECESSARY_SORT_BY),
LintId::of(&unwrap::UNNECESSARY_UNWRAP),
LintId::of(&useless_conversion::USELESS_CONVERSION),
LintId::of(&zero_div_zero::ZERO_DIVIDED_BY_ZERO),
Expand Down
14 changes: 7 additions & 7 deletions src/lintlist/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1984,13 +1984,6 @@ pub static ref ALL_LINTS: Vec<Lint> = vec![
deprecation: None,
module: "slow_vector_initialization",
},
Lint {
name: "sort_by_key_reverse",
group: "complexity",
desc: "Use of `Vec::sort_by` when `Vec::sort_by_key` would be clearer",
deprecation: None,
module: "sort_by_key_reverse",
},
Lint {
name: "string_add",
group: "restriction",
Expand Down Expand Up @@ -2299,6 +2292,13 @@ pub static ref ALL_LINTS: Vec<Lint> = vec![
deprecation: None,
module: "no_effect",
},
Lint {
name: "unnecessary_sort_by",
group: "complexity",
desc: "Use of `Vec::sort_by` when `Vec::sort_by_key` or `Vec::sort` would be clearer",
deprecation: None,
module: "unnecessary_sort_by",
},
Lint {
name: "unnecessary_unwrap",
group: "complexity",
Expand Down