Rollup of 4 pull requests #72074
Merged
Rollup of 4 pull requests #72074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls in updated MSVC detection logic landed in alexcrichton/cc-rs#488
Rework MIR drop tree lowering This PR changes how drops are generated in MIR construction. This is the first half of the fix for rust-lang#47949. Rather than generating the drops for a given unwind/break/continue/return/generator drop path as soon as they are needed, the required drops are recorded and get generated later. The motivation for this is * It simplifies the caching scheme, because it's now possible to walk up the currently scheduled drop tree to recover state. * The basic block order for MIR more closely resembles execution order. This PR also: * Highlights cleanup blocks in the graphviz MIR output. * Removes some unnecessary drop flag assignments.
…lacrum Update the `cc` crate Pulls in updated MSVC detection logic landed in alexcrichton/cc-rs#488
…-types-section, r=kinnison,ollie27 Sort "implementations on foreign types" section in the sidebar Fixes rust-lang#71926. We were sorting by the ID instead of sorting by the name. They're not in the same order as the implementations but I think it makes more sense this way considering this is what we do for the methods as well. r? @kinnison cc @rust-lang/rustdoc
…lan-DPC Add missing backtick in E0569 explanation r? @Dylan-DPC
|
📌 Commit f2b655f has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
|
There was a big perf regression for one of the @alexcrichton, @GuillaumeGomez, @matthewjasper: any idea which PR might have caused this? |
|
It's #71840, here's pre-landing perf from that PR; also see #71840 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
cccrate #71882 (Update thecccrate)Failed merges:
r? @ghost