Create bogus-error-#39161.rs #71333
Closed
Create bogus-error-#39161.rs #71333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
JohnTitor
reviewed
Apr 19, 2020
There was a problem hiding this comment.
So, I think this test would be better:
pub struct X {
pub a: i32,
pub b: i32,
}
fn main() {
const DX: X = X { a: 0, b: 0 };
const _X1: X = X { a: 1, ..DX };
let _x2 = X { a: 1, b: 2, ..DX };
const _X3: X = X { a: 1, b: 2, ..DX };
}This doesn't need allow attribute and emit warnings.
| @@ -0,0 +1,10 @@ | |||
| // run-pass | |||
There was a problem hiding this comment.
I think this could be // check-pass?
|
Also, could you place this test in |
JohnTitor
added
S-waiting-on-author
|
@YesSeri this is a triage bump. |
|
I'm going to go ahead and close this PR, as it's over 3 months old. @YesSeri please feel free to re-open if you get a chance to address @JohnTitor's feedback. ❤️ |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 21, 2021
…ohnTitor Add regression test for issue rust-lang#39161 Closes rust-lang#39161 Based on feedback from `@JohnTitor` in rust-lang#71333 r? `@JohnTitor`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 21, 2021
…ohnTitor Add regression test for issue rust-lang#39161 Closes rust-lang#39161 Based on feedback from ``@JohnTitor`` in rust-lang#71333 r? ``@JohnTitor``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #39161
It is still working.