Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodules: update clippy from af5940b7 to d236b30a #71139

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

matthiaskrgr
Copy link
Member

Changes:

rustup https://github.com/rust-lang/rust/pull/70643
Explain panic on `E0463` in integration tests
Temporarily disable rustfmt integration test
Cleanup: Use rustc's is_proc_macro_attr
Cleanup: Use our `sym!` macro more
Fixes #5405: redundant clone false positive with arrays
update lints
verbose_bit_mask: fix bit mask used in docs
Update documentation for new_ret_no_self

Fixes #71114

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2020
@matthiaskrgr
Copy link
Member Author

r? @Dylan-DPC

@Dylan-DPC-zz
Copy link

@bors p=1

@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Contributor

bors commented Apr 14, 2020

📌 Commit b31e043492f67d1a15d7617f97e16185a8d538b1 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2020
@bors
Copy link
Contributor

bors commented Apr 15, 2020

⌛ Testing commit b31e043492f67d1a15d7617f97e16185a8d538b1 with merge 92bc0a43f20506cdf6360ce12225120e6ce245d6...

@matthiaskrgr
Copy link
Member Author

#71116 broke clippy again so this won't merge right now

@Dylan-DPC-zz
Copy link

thanks

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2020
@Centril
Copy link
Contributor

Centril commented Apr 15, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2020
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2020
@Dylan-DPC-zz
Copy link

@matthiaskrgr i think better to close this and submit a new PR right?

@matthiaskrgr
Copy link
Member Author

The rustup in CI right now, I want to wait another hour or so until another batch of PRs is merged into clippy and will update the pr afterwards.

Changes:
````
Rename dummy_hir_id -> parent_hir_id
rustup rust-lang#71116
Change default many single char names threshold
Better precedence case management + more tests
Use only check_expr with parent expr and precedence
Check for Deref trait impl + add fixed version
Report using stmts and expr + tests
Global rework + fix imports
Working basic dereference clip
Add test for zero single char names
Make the single char threshold strict inequality
large_enum_variant: Report sizes of variants
Refactor: Use rustc's `match_def_path`
deps: bump compiletest-rs from 0.4 to 0.5
rustup rust-lang#70643
Explain panic on `E0463` in integration tests
Temporarily disable rustfmt integration test
result_map_unit_fn: Fix incorrect UI tests
Cleanup: Use rustc's is_proc_macro_attr
Cleanup: Use our `sym!` macro more
Fixes rust-lang#5405: redundant clone false positive with arrays
Disallow bit-shifting in `integer_arithmetic` lint
update lints
cargo dev fmt
Make use of Option/Result diagnostic items
Make use of some existing diagnostic items
Say that diagnostic items are preferred over paths
verbose_bit_mask: fix bit mask used in docs
Update documentation for new_ret_no_self
Update doc generation script
Add lint on large const arrays
Make the epsilon note spanless
Split check_fn function
Indicate when arrays are compared in error message
Make epsilon note spanless when comparing arrays
Add float cmp const tests for arrays
Add float cmp tests for arrays
Handle constant arrays with single value
Don't show comparison suggestion for arrays
Allow for const arrays of zeros
Handle evaluating constant index expression
Add handling of float arrays to miri_to_const
Update stderr of float_cmp test
Update field names in is_float
Add tests for float in array comparison
Add lint when comparing floats in an array
````

Fixes rust-lang#71114
@matthiaskrgr
Copy link
Member Author

updated

@Dylan-DPC-zz
Copy link

the tree is currently closed. once it's opened, this pr will run first :)

@bors r+

@bors
Copy link
Contributor

bors commented Apr 15, 2020

📌 Commit fada4b2 has been approved by Dylan-DPC

@bors
Copy link
Contributor

bors commented Apr 15, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2020
@JohnTitor
Copy link
Member

CI issue is fixed now.
@bors treeclosed-

@bors
Copy link
Contributor

bors commented Apr 15, 2020

⌛ Testing commit fada4b2 with merge d223029...

@bors
Copy link
Contributor

bors commented Apr 15, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing d223029 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 15, 2020
@bors bors merged commit d223029 into rust-lang:master Apr 15, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #71139!

Tested on commit d223029.
Direct link to PR: #71139

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 15, 2020
Tested on commit rust-lang/rust@d223029.
Direct link to PR: <rust-lang/rust#71139>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
@bors bors mentioned this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#70643
7 participants