Remove unnecessary TypeFlags::NOMINAL_FLAGS #70915
Conversation
This was a relic from when we had "nominal flags" and "cached properties." The latter no longer exists, so nominal flags are no longer necessary. In fact, every flag is considered a nominal flag. I went ahead and removed all references to NOMINAL_FLAGS. Fixes rust-lang#70836
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ Thanks! |
|
📌 Commit 4cdb206 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
|
r? @eddyb |
Rollup of 9 pull requests Successful merges: - rust-lang#70789 (remove false positives of unused_braces) - rust-lang#70847 (ci: move /var/lib/docker to /mnt on GHA) - rust-lang#70850 (BTreeMap first last proposal tweaks) - rust-lang#70876 (Use a `SmallVec` for `Cache::predecessors`.) - rust-lang#70883 (Clean up E0507 explanation) - rust-lang#70892 (wf: refactor `compute_trait_ref`) - rust-lang#70914 (Corrects a typo in rustdoc documentation.) - rust-lang#70915 (Remove unnecessary TypeFlags::NOMINAL_FLAGS) - rust-lang#70927 (Clean up E0510 explanation) Failed merges: r? @ghost
This was a relic from when we had "nominal flags" and "cached
properties." The latter no longer exists, so nominal flags are no
longer necessary. In fact, every flag is considered a nominal flag. I
went ahead and removed all references to NOMINAL_FLAGS.
Fixes #70836