Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs in AllocRef #70691

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Improve docs in AllocRef #70691

merged 1 commit into from
Apr 3, 2020

Conversation

TimDiekmann
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2020
@TimDiekmann TimDiekmann mentioned this pull request Apr 2, 2020
Merged
@RalfJung
Copy link
Member

RalfJung commented Apr 2, 2020

LGTM but keep in mind that I have no involvement with the allocator WG and didn't know about the new API until 5h ago.
If you still want my review, r=me.

@TimDiekmann
Copy link
Member Author

The changes do not affect the allocator-wg directly, only the trait. You are the expert on undefined behavior and AllocInit::Uninitialized is basically a noop and Zeroed is basically calling ptr::write_bytes(0). The other changes were simply overlooked last time.

As I'm not a team member I can't r=you.

@RalfJung
Copy link
Member

RalfJung commented Apr 2, 2020

Okay. @bors r+

@bors
Copy link
Contributor

bors commented Apr 2, 2020

📌 Commit 0b61239 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2020
@RalfJung
Copy link
Member

RalfJung commented Apr 2, 2020

@bors rollup

@TimDiekmann
Copy link
Member Author

TimDiekmann commented Apr 2, 2020 •
edited
Loading

Thanks. You may want to add a rollup=always You were faster...

Centril added a commit to Centril/rust that referenced this pull request Apr 2, 2020
@Centril
Rollup merge of rust-lang#70691 - TimDiekmann:allocref-docs, r=RalfJung
921dcaf 
Improve docs in `AllocRef`

r? @RalfJung
@Centril Centril mentioned this pull request Apr 2, 2020
Closed
@Centril Centril mentioned this pull request Apr 2, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2020
@bors
Auto merge of rust-lang#70722 - Centril:rollup-ar4gn1x, r=Centril
c520802 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#70487 (Stabilize float::to_int_unchecked)
 - rust-lang#70595 (Remove unused discriminant reads from MIR bodies)
 - rust-lang#70691 (Improve docs in `AllocRef`)
 - rust-lang#70694 (Use Self over specific type in return position)
 - rust-lang#70700 (Expand on platform details of `include_xxx` macros)
 - rust-lang#70708 (Fix typo in u8::to_ascii_uppercase and u8::to_ascii_lowercase)
 - rust-lang#70716 (Unerase regions in infer_placeholder_type)

Failed merges:

r? @ghost
@bors bors merged commit e07f57c into rust-lang:master Apr 3, 2020
@TimDiekmann TimDiekmann deleted the allocref-docs branch April 26, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimDiekmann @RalfJung @bors @rust-highfive