Skip to content

Improve error messages for raw strings (#60762) #70522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 1, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up redudant conditions and match exprs
  • Loading branch information
rcoh committed Mar 30, 2020
commit 20e21902bb993487c1486f2dd33d3bd65101f00c
2 changes: 1 addition & 1 deletion src/librustc_lexer/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ impl Cursor<'_> {
n_end_hashes,
possible_terminator_offset: None,
};
} else if n_end_hashes > 0 && n_end_hashes > max_hashes {
} else if n_end_hashes > max_hashes {
// Keep track of possible terminators to give a hint about where there might be
// a missing terminator
possible_terminator_offset =
Expand Down
21 changes: 10 additions & 11 deletions src/librustc_parse/parser/diagnostics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -287,15 +287,14 @@ impl<'a> Parser<'a> {
}

fn check_too_many_raw_str_terminators(&mut self, err: &mut DiagnosticBuilder<'_>) -> bool {
let prev_token_raw_str = match self.prev_token.kind {
TokenKind::Literal(Lit {
kind: LitKind::StrRaw(n) | LitKind::ByteStrRaw(n), ..
}) => Some(n),
_ => None,
};

if let Some(n_hashes) = prev_token_raw_str {
if self.token.kind == TokenKind::Pound {
match (&self.prev_token.kind, &self.token.kind) {
(
TokenKind::Literal(Lit {
kind: LitKind::StrRaw(n_hashes) | LitKind::ByteStrRaw(n_hashes),
..
}),
TokenKind::Pound,
) => {
err.set_primary_message("too many `#` when terminating raw string");
err.span_suggestion(
self.token.span,
Expand All @@ -304,10 +303,10 @@ impl<'a> Parser<'a> {
Applicability::MachineApplicable,
);
err.note(&format!("the raw string started with {} `#`s", n_hashes));
return true;
true
}
_ => false,
}
false
}

pub fn maybe_annotate_with_ascription(
Expand Down