Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also run UnusedBrokenConst on associated consts. #70017

Closed
wants to merge 11 commits into from
Closed

Also run UnusedBrokenConst on associated consts. #70017

wants to merge 11 commits into from

Commits on Mar 29, 2020

  1. Set up test cases which demonstrate the issue.

    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    a105875 View commit details
    Browse the repository at this point in the history

  2. Add more trace info.

    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    c0036bd View commit details
    Browse the repository at this point in the history

  3. UnusedBrokenConst: Also check associated consts. 

    Previously, we would only end up doing checks for consts which
const_prop was attempted on. This meant associated consts which didn't
end up explicitly used in a crate weren't visited, so weren't checked.
    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    5cca751 View commit details
    Browse the repository at this point in the history

  4. Fix a comment typo 

    It ain't much, but it's honest work.
    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    57e9bc4 View commit details
    Browse the repository at this point in the history

  5. Run RustFmt

    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    73fd75f View commit details
    Browse the repository at this point in the history

  6. Add stderrs with duplicate diagnostics.

    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    d2a1b80 View commit details
    Browse the repository at this point in the history

  7. Skip reveal_all if needs_subst.

    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    2bd7a23 View commit details
    Browse the repository at this point in the history

  8. Run RustFmt

    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    dc00413 View commit details
    Browse the repository at this point in the history

  9. Update test case with link to issue.

    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    27a9371 View commit details
    Browse the repository at this point in the history

  10. Don't fail validation for pointers to param T.

    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    d95a610 View commit details
    Browse the repository at this point in the history

  11. Accept duplicate on const_errs (for now).

    @jumbatm
    jumbatm committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    6d33a18 View commit details
    Browse the repository at this point in the history