Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
Collaborator
|
📌 Commit 27fdf7e049ce1776d59bb0a6819185819cf724eb has been approved by |
bors
added
S-waiting-on-bors
Member
Author
|
@Dylan-DPC Would you mind my addressing the remaining things above in this PR? (Sorry, I should have marked this PR as WIP.) |
Member
Author
|
@bors r- ^-- |
bors
added
S-waiting-on-author
|
You can also do draft prs which are more noticeable |
JohnTitor
force-pushed
the
clean-up-unstable-book
branch
from
27fdf7e to
4c9e87e
Compare
Member
Author
Contributor
|
@JohnTitor |
Member
Author
|
Ah, okay! Then tracking issue can be None? |
Contributor
|
Yes. |
JohnTitor
force-pushed
the
clean-up-unstable-book
branch
from
c55fc19 to
c55df37
Compare
JohnTitor
added
S-waiting-on-review
Member
Author
|
I think it's ready to review. |
Member
Author
|
I think almost should be fine but I'm not sure about tidy things, perhaps @Mark-Simulacrum thoughts? |
Member
|
@bors r+ |
Collaborator
|
📌 Commit c55df37 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 8, 2020
…=Mark-Simulacrum Clean up unstable book - rust-lang#58402's feature was renamed to `tidy_test_never_used_anywhere_else` and it is now used for tidy only - `read_initializer` link is wrong and the doc should be auto-generated so removed - Add dummy doc for `link_cfg` - Stop generating `compiler_builtins_lib` doc in favor of b8ccc0f - Make `rustc_attrs` tracking issue "None"
bors
added a commit
that referenced
this pull request
Mar 8, 2020
Rollup of 8 pull requests Successful merges: - #69422 (Remove use of `unwrap()` from save-analysis) - #69548 (Turn trailing tokens in `assert!()` into hard errors) - #69561 (Clean up unstable book) - #69599 (check_binding_alt_eq_ty: improve precision wrt. `if let`) - #69641 (Update books) - #69776 (Fix & test leak of some BTreeMap nodes on panic during `into_iter`) - #69805 (resolve: Modernize some naming) - #69810 (test(bindings_after_at): add dynamic drop tests for bindings_after_at) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tidy_test_never_used_anywhere_elseand it is now used for tidy onlyread_initializerlink is wrong and the doc should be auto-generated so removedlink_cfgcompiler_builtins_libdoc in favor of b8ccc0frustc_attrstracking issue "None"