Create E0748 error code for unterminated raw strings #69260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in diagnostic error codes |
rust-highfive
added
the
S-waiting-on-review
Xanewok
approved these changes
Feb 18, 2020
|
cc @rust-lang/compiler |
varkor
approved these changes
Feb 26, 2020
| let dolphins = r##"Dolphins!"#; // error! | ||
| ``` | ||
| To terminate a raw string, you have to have the same number of `#` at the end | ||
| than at the beginning. Example: |
There was a problem hiding this comment.
Suggested change
| than at the beginning. Example: | |
| as at the beginning. Example: |
Comment on lines
12
to
13
| let dolphins = r#"Dolphins!"#; // one `#` at the beginning, one at the end so | ||
| // all good! |
There was a problem hiding this comment.
Suggested change
| let dolphins = r#"Dolphins!"#; // one `#` at the beginning, one at the end so | |
| // all good! | |
| let dolphins = r#"Dolphins!"#; // One `#` at the beginning; one at the end: | |
| // all good! |
estebank
approved these changes
Feb 27, 2020
|
also r=me after applying varkor's changes |
|
@bors: r=varkor,estebank |
|
📌 Commit e2da93acb2432c26a74ea83128d72884d8b0cdf3 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #68434) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
E0747 has been taken so let's move to E0748... |
GuillaumeGomez
force-pushed
the
create-E0747-error-code
branch
from
e2da93a
to
e273828
Compare
|
@bors: r=varkor,estebank |
|
📌 Commit e273828 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Feb 29, 2020
Tested on commit rust-lang/rust@e9bca51. Direct link to PR: <rust-lang/rust#69260> 🎉 rls on linux: test-fail → test-pass (cc @Xanewok).
GuillaumeGomez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening of #66035.
r? @estebank