Skip to content

[self-profiler] Two small cleanups #68531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2020
Merged

[self-profiler] Two small cleanups #68531

merged 2 commits into from
Jan 27, 2020

Conversation

@wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Jan 25, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2020
@michaelwoerister
Copy link
Member

michaelwoerister commented Jan 27, 2020

Nice! I didn't know ThreadId::as_u64() was a thing.

@michaelwoerister
Copy link
Member

michaelwoerister commented Jan 27, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 27, 2020

📌 Commit 2acf5a3 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2020
@wesleywiser
Copy link
Member Author

wesleywiser commented Jan 27, 2020

It's pretty new iirc.

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jan 27, 2020
@pietroalbini
Rollup merge of rust-lang#68531 - wesleywiser:cleanup_self_profiler, …
9188bab 
…r=michaelwoerister

[self-profiler] Two small cleanups

r? @michaelwoerister
@pietroalbini pietroalbini mentioned this pull request Jan 27, 2020
Merged
bors added a commit that referenced this pull request Jan 27, 2020
@bors
Auto merge of #68566 - pietroalbini:rollup-22hbo3e, r=pietroalbini
8a79d08 
Rollup of 4 pull requests

Successful merges:

 - #67928 (Update RELEASES.md for 1.41.0)
 - #68370 (Ensure that we error when calling "const extern fn" with wrong convention)
 - #68531 ([self-profiler] Two small cleanups)
 - #68562 (Fix spelling errors)

Failed merges:

r? @ghost
@bors bors merged commit 2acf5a3 into rust-lang:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelwoerister michaelwoerister

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wesleywiser @michaelwoerister @bors @rust-highfive