Record lifetime constraints inside generator interior #68362

csmoe · 2020-01-19T09:01:17Z

tmandry · 2020-02-18T18:27:28Z

Ping from triage. @csmoe, what's the status of this PR?

src/librustc_infer/infer/region_constraints/mod.rs

Aaron1011 · 2020-03-05T05:00:54Z

I think it would also be a good idea to record the RegionVariableOrigin for each region that we record a predicate for. This will allow us to generate more precise error messages during borrowck.

src/librustc/ty/context.rs

rust-highfive · 2020-03-24T10:28:30Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-24T09:43:43.8179322Z ========================== Starting Command Output ===========================
2020-03-24T09:43:43.8183023Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/a185cb33-1ed1-4e0d-9277-abef8a0c4c6b.sh
2020-03-24T09:43:43.8183280Z 
2020-03-24T09:43:43.8187928Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-24T09:43:43.8207884Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68362/merge to s
2020-03-24T09:43:43.8211143Z Task         : Get sources
2020-03-24T09:43:43.8211459Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-24T09:43:43.8211760Z Version      : 1.0.0
2020-03-24T09:43:43.8211967Z Author       : Microsoft
---
2020-03-24T09:43:44.8111688Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-24T09:43:44.8120887Z ##[command]git config gc.auto 0
2020-03-24T09:43:44.8124742Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-24T09:43:44.8129274Z ##[command]git config --get-all http.proxy
2020-03-24T09:43:44.8136486Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68362/merge:refs/remotes/pull/68362/merge
---
2020-03-24T09:50:35.0800988Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-24T09:50:44.4457403Z    Compiling rustc_session v0.0.0 (/checkout/src/librustc_session)
2020-03-24T09:50:50.3223591Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-24T09:51:01.4900510Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-24T09:51:04.4598480Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-24T09:51:05.7422667Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-24T09:51:36.7199821Z    Compiling rustc_ast_passes v0.0.0 (/checkout/src/librustc_ast_passes)
2020-03-24T09:51:44.5724163Z    Compiling rustc_expand v0.0.0 (/checkout/src/librustc_expand)
2020-03-24T09:52:30.5936327Z    Compiling rustc_builtin_macros v0.0.0 (/checkout/src/librustc_builtin_macros)
---
2020-03-24T10:11:35.1094411Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-24T10:11:46.8635860Z    Compiling rustc_session v0.0.0 (/checkout/src/librustc_session)
2020-03-24T10:11:54.6815661Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-24T10:12:08.5873262Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-24T10:12:12.1339765Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-24T10:12:13.7847853Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-24T10:12:54.9262087Z    Compiling rustc_ast_passes v0.0.0 (/checkout/src/librustc_ast_passes)
2020-03-24T10:13:04.4497383Z    Compiling rustc_expand v0.0.0 (/checkout/src/librustc_expand)
2020-03-24T10:14:04.3774788Z    Compiling rustc_builtin_macros v0.0.0 (/checkout/src/librustc_builtin_macros)
---
2020-03-24T10:27:24.6554021Z error: internal compiler error: unexpected panic
2020-03-24T10:27:24.6556434Z 
2020-03-24T10:27:24.6561007Z note: the compiler unexpectedly panicked. this is a bug.
2020-03-24T10:27:24.6563314Z 
2020-03-24T10:27:24.6567605Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2020-03-24T10:27:24.6574047Z note: rustc 1.44.0-nightly (97ebf7940 2020-03-24) running on x86_64-unknown-linux-gnu
2020-03-24T10:27:24.6576480Z 
2020-03-24T10:27:24.6576480Z 
2020-03-24T10:27:24.6580885Z note: compiler flags: -Z macro-backtrace -Z unstable-options -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C debuginfo=0 -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C llvm-args=-import-instr-limit=10 -C debug-assertions=n --crate-type lib
2020-03-24T10:27:24.6605522Z note: some of the compiler flags provided by cargo are hidden
2020-03-24T10:27:24.6607979Z 
2020-03-24T10:27:24.6765462Z error: could not compile `rustc_interface`.
2020-03-24T10:27:24.6769059Z 
---
2020-03-24T10:28:10.6898287Z   local time: Tue Mar 24 10:28:10 UTC 2020
2020-03-24T10:28:10.8514824Z   network time: Tue, 24 Mar 2020 10:28:10 GMT
2020-03-24T10:28:10.8520946Z == end clock drift check ==
2020-03-24T10:28:11.4453734Z 
2020-03-24T10:28:11.4502844Z ##[error]Bash exited with code '1'.
2020-03-24T10:28:11.4522075Z ##[section]Finishing: Run build
2020-03-24T10:28:11.4562111Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68362/merge to s
2020-03-24T10:28:11.4566091Z Task         : Get sources
2020-03-24T10:28:11.4566547Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-24T10:28:11.4566771Z Version      : 1.0.0
2020-03-24T10:28:11.4566927Z Author       : Microsoft
2020-03-24T10:28:11.4566927Z Author       : Microsoft
2020-03-24T10:28:11.4567196Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-24T10:28:11.4567481Z ==============================================================================
2020-03-24T10:28:11.7253757Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-24T10:28:11.7305671Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68362/merge to s
2020-03-24T10:28:11.7369656Z Cleaning up task key
2020-03-24T10:28:11.7370561Z Start cleaning up orphan processes.
2020-03-24T10:28:11.7535329Z Terminate orphan process: pid (3407) (python)
2020-03-24T10:28:11.7679299Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

benschulz · 2020-03-25T13:08:16Z

@csmoe, in case you're unaware, the Github account of whomever you originally asked for a review is gone.

Aaron1011 · 2020-03-25T16:51:24Z

@csmoe: Note that I'm not a part of any Rust team, so you'll probably want someone else to review this as well 😄

rust-highfive · 2020-04-30T04:52:14Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/7c07ff92-e211-487c-9d2f-b209a7a653db.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/68362/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68362/merge:refs/remotes/pull/68362/merge
---
 ---> f7353ccad5b1
Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
 ---> Using cache
 ---> ed38efbaa060
Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors &&            python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu &&            python3 ../x.py build --stage 0 src/tools/build-manifest &&            python3 ../x.py test --stage 0 src/tools/compiletest &&            python3 ../x.py test src/tools/tidy &&            /scripts/validate-toolstate.sh
 ---> c5008ef7ae8e
Successfully built c5008ef7ae8e
Successfully tagged rust-ci:latest
Built container sha256:c5008ef7ae8e94d7ef502e3cef26e61208e14ebdb36913f3a8bb86291bd6430b
Built container sha256:c5008ef7ae8e94d7ef502e3cef26e61208e14ebdb36913f3a8bb86291bd6430b
Looks like docker image is the same as before, not uploading
[CI_JOB_NAME=mingw-check]
[CI_JOB_NAME=mingw-check]
== clock drift check ==
  local time: Thu Apr 30 04:35:31 UTC 2020
  network time: Thu, 30 Apr 2020 04:35:31 GMT
Starting sccache server...
configure: processing command line
configure: 
configure: rust.parallel-compiler := True
---
    Checking unicode-width v0.1.6
    Checking getopts v0.2.21
    Checking test v0.0.0 (/checkout/src/libtest)
    Finished release [optimized] target(s) in 20.86s
{"reason":"build-finished","success":true}
    Checking cfg-if v0.1.10
   Compiling libc v0.2.69
   Compiling semver-parser v0.7.0
    Checking scopeguard v1.0.0
---
    Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
    Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
    Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking rustc_attr v0.0.0 (/checkout/src/librustc_attr)
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
    Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
    Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
    Checking rustc_ty v0.0.0 (/checkout/src/librustc_ty)
error[E0023]: this pattern has 1 field, but the corresponding tuple variant has 2 fields
   --> src/librustc_ty/needs_drop.rs:110:29
    |
110 |   ...                   ty::GeneratorWitness(tys) => tcx.erase_late_bound_regions(tys),
    | 
    | 
   ::: /checkout/src/librustc_middle/ty/sty.rs:171:5
171 | /     GeneratorWitness(
172 | |         Binder<&'tcx List<Ty<'tcx>>>,
172 | |         Binder<&'tcx List<Ty<'tcx>>>,
173 | |         Binder<&'tcx List<ty::RegionOutlivesPredicate<'tcx>>>,
    | |_____- tuple variant defined here

error: aborting due to previous error


For more information about this error, try `rustc --explain E0023`.
error: could not compile `rustc_ty`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
{"reason":"build-finished","success":false}
error: build failed
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "check" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--color" "always" "--features" " llvm" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap check
Build completed unsuccessfully in 0:03:33
== clock drift check ==
== clock drift check ==
  local time: Thu Apr 30 04:39:05 UTC 2020
  network time: Thu, 30 Apr 2020 04:39:05 GMT


##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/68362/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/68362/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3500) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-04-30T12:03:48Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/c2c18c84-fe4d-4c84-afbe-8df3be27e489.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/68362/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68362/merge:refs/remotes/pull/68362/merge
---
 ---> cb2676f08729
Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
 ---> Using cache
 ---> df25ce111862
Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
 ---> 599b9ac96b27
Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
 ---> Using cache
 ---> 091087e35a36
---
Looks like docker image is the same as before, not uploading
[CI_JOB_NAME=x86_64-gnu-llvm-8]
[CI_JOB_NAME=x86_64-gnu-llvm-8]
== clock drift check ==
  local time: Thu Apr 30 11:22:32 UTC 2020
  network time: Thu, 30 Apr 2020 11:22:32 GMT
Starting sccache server...
configure: processing command line
configure: 
configure: rust.dist-src        := False
---
   Compiling term v0.0.0 (/checkout/src/libterm)
   Compiling unicode-width v0.1.6
   Compiling getopts v0.2.21
   Compiling test v0.0.0 (/checkout/src/libtest)
{"reason":"build-finished","success":true}
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling cfg-if v0.1.10
   Compiling libc v0.2.69
---
   Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
   Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
   Compiling rustc_privacy v0.0.0 (/checkout/src/librustc_privacy)
   Compiling rustc_plugin_impl v0.0.0 (/checkout/src/librustc_plugin_impl)
   Compiling rustc-main v0.0.0 (/checkout/src/rustc)
    Finished release [optimized] target(s) in 18m 45s
{"reason":"build-finished","success":true}
Assembling stage1 compiler (x86_64-unknown-linux-gnu)
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling cc v1.0.50
   Compiling core v0.0.0 (/checkout/src/libcore)
---
   Compiling unicode-width v0.1.6
   Compiling getopts v0.2.21
   Compiling test v0.0.0 (/checkout/src/libtest)
    Finished release [optimized] target(s) in 59.98s
{"reason":"build-finished","success":true}
Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling cfg-if v0.1.10
   Compiling libc v0.2.69
   Compiling semver-parser v0.7.0
---
   Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
   Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
note: rustc 1.45.0-nightly (dd39537a0 2020-04-30) running on x86_64-unknown-linux-gnu


note: compiler flags: -Z macro-backtrace -Z unstable-options -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C debuginfo=0 -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C llvm-args=-import-instr-limit=10 -C debug-assertions=n --crate-type lib
note: some of the compiler flags provided by cargo are hidden

error: could not compile `rustc_interface`.


To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
{"reason":"build-finished","success":false}
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" " llvm" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
expected success, got: exit code: 101
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
Build completed unsuccessfully in 0:39:38
Build completed unsuccessfully in 0:39:38
== clock drift check ==
  local time: Thu Apr 30 12:03:42 UTC 2020
  network time: Thu, 30 Apr 2020 12:03:42 GMT


##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/68362/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/68362/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3673) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Dylan-DPC-zz · 2020-05-08T15:33:45Z

@csmoe any updates?

csmoe · 2020-05-08T15:48:30Z

@Dylan-DPC working on the panic.

bors · 2020-05-22T01:32:57Z

☔ The latest upstream changes (presumably #72433) made this pull request unmergeable. Please resolve the merge conflicts.

crlf0710 · 2020-05-30T00:30:59Z

This needs a rebase.

Muirrum · 2020-07-16T23:22:46Z

@csmoe This is a triage bump.

Dylan-DPC-zz · 2020-08-01T13:50:02Z

Closing this as inactive. Thanks

hdhoang added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2020