Skip to content

Rollup of 8 pull requests #68115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Jan 11, 2020
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
b650e91
Label unmarked time
Zoxc Jan 9, 2020
5918c18
Tweak timers
Zoxc Jan 9, 2020
1c9f999
Add llvm-skip-rebuild to opts
Jan 9, 2020
fcd850f
Do not ICE on unicode next point
estebank Jan 10, 2020
0bbbd5d
Match llvm-skip-rebuild flag
Jan 9, 2020
7e50b59
Prefer llvm-skip-rebuild flag value over config.toml
Jan 9, 2020
cd9a73d
make use of pointer::is_null
tesuji Jan 10, 2020
8ca5564
Clarify suggestion for E0013
varkor Jan 10, 2020
137a31d
Inline to make OsStr::is_empty zero cost
tesuji Jan 10, 2020
eca1e8b
Inline PathBuf::deref to make it zero cost
tesuji Jan 10, 2020
ea6bb7f
Inline `AsRef<Path> for str`
tesuji Jan 10, 2020
bf1d20c
Inline `impl From<OsString> for PathBuf`
tesuji Jan 10, 2020
3250057
Fix `next_point` to be unicode aware
estebank Jan 10, 2020
d558f6a
Fix invalid bounding box
estebank Jan 10, 2020
cd5ab97
inline `impl AsRef<OsStr> for OsString`
tesuji Jan 10, 2020
76e698f
inline `impl AsRef<Path> for PathBuf`
tesuji Jan 10, 2020
b93ef68
Change `next_point` when `shrink_to_hi` is more appropriate
estebank Jan 10, 2020
f6e9fd0
Add ICE regression tests
estebank Jan 10, 2020
5f3f1a3
inline `impl From<String> for Box<dyn Error + Send + Sync>`
tesuji Jan 10, 2020
799efd3
Fix issue with using `self` module via indirection
varkor Jan 10, 2020
6007641
gating diagnostics -> rustc_session::parse
Centril Jan 2, 2020
c944e6a
document feature_err et. al
Centril Jan 2, 2020
7c78090
get_features -> rustc_parse::config
Centril Jan 2, 2020
1af8c10
simplify feature_err imports
Centril Jan 2, 2020
fff5ef6
canonicalize rustc::session import
Centril Jan 2, 2020
d247ac4
Remove unused derives
Centril Jan 5, 2020
82eeb85
prepare for moving BuiltinLintDiagnostics to rustc_session
Centril Jan 5, 2020
7dbccf5
buffered lint infra -> rustc_session
Centril Jan 5, 2020
45f2764
prepare moving HardwiredLints to rustc_session
Centril Jan 5, 2020
2b44a6c
move {rustc -> rustc_session}::lint::builtin
Centril Jan 5, 2020
f361b71
nix syntax::early_buffered_lints
Centril Jan 5, 2020
ed69fbb
ast_validation -> new crate rustc_ast_passes
Centril Jan 5, 2020
6cbcb83
{syntax -> rustc_ast_passes}::feature_gate
Centril Jan 5, 2020
ae213db
{syntax -> rustc_ast_passes}::show_span
Centril Jan 5, 2020
7d6548a
rustc_passes: remove unused rustc_parse dep
Centril Jan 5, 2020
b4809d0
appease rustfmt
Centril Jan 5, 2020
d0d1c60
pacify tidy by nixing added docs :(
Centril Jan 5, 2020
682f500
fix fallout in ui-fulldeps
Centril Jan 8, 2020
76edc5c
Rollup merge of #67666 - lzutao:ptr-null-cmp, r=dtolnay
Centril Jan 11, 2020
9634e1f
Rollup merge of #67806 - Centril:splitsynmore, r=petrochenkov
Centril Jan 11, 2020
8c0c5c7
Rollup merge of #68043 - Zoxc:missing-timers, r=wesleywiser
Centril Jan 11, 2020
ef3e360
Rollup merge of #68074 - matthew-healy:skip-llvm-rebuild-option, r=Ce…
Centril Jan 11, 2020
ba14f94
Rollup merge of #68079 - varkor:E0013-clarify, r=Centril
Centril Jan 11, 2020
cacda2d
Rollup merge of #68084 - estebank:ice-68000, r=varkor
Centril Jan 11, 2020
c960c3e
Rollup merge of #68102 - lzutao:inline, r=alexcrichton
Centril Jan 11, 2020
04a340f
Rollup merge of #68106 - varkor:self_self_use, r=estebank
Centril Jan 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prefer llvm-skip-rebuild flag value over config.toml
  • Loading branch information
Matthew Healy committed Jan 10, 2020
commit 7e50b599bfeb75f7be1d5a1fa855e37ec6d0e65d
8 changes: 6 additions & 2 deletions src/bootstrap/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -493,9 +493,13 @@ impl Config {
config.mandir = install.mandir.clone().map(PathBuf::from);
}

// We want the llvm-skip-rebuild flag to take precedence over the
// skip-rebuild config.toml option so we store it separately
// so that we can infer the right value
let mut llvm_skip_rebuild = flags.llvm_skip_rebuild;

// Store off these values as options because if they're not provided
// we'll infer default values for them later
let mut llvm_skip_rebuild = None;
let mut llvm_assertions = None;
let mut debug = None;
let mut debug_assertions = None;
Expand All @@ -517,7 +521,7 @@ impl Config {
}
set(&mut config.ninja, llvm.ninja);
llvm_assertions = llvm.assertions;
llvm_skip_rebuild = llvm.skip_rebuild;
llvm_skip_rebuild = llvm_skip_rebuild.or(llvm.skip_rebuild);
set(&mut config.llvm_optimize, llvm.optimize);
set(&mut config.llvm_thin_lto, llvm.thin_lto);
set(&mut config.llvm_release_debuginfo, llvm.release_debuginfo);
Expand Down