Skip to content

Move numeric consts to associated consts #67913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
+878 −859
Closed

Move numeric consts to associated consts #67913

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f5e0f4d
Deprecate min_value() and max_value() for all integers
faern Dec 16, 2019
5450cc7
Deprecate MIN/MAX constants in integer modules
faern Dec 16, 2019
3afdf3f
Deprecate all integer modules
faern Dec 16, 2019
8fbd3ad
Add MIN/MAX associated constants to all integer types
faern Dec 16, 2019
c127d8f
Don't mention interger modules on primitive docs
faern Dec 17, 2019
5f687fb
Replace all usages of min_value/max_value with assoc const MIN/MAX
faern Dec 17, 2019
7bb3a45
Remove usage of module level MAX/MIN constants
faern Dec 17, 2019
57ad77b
Add associated constants on floats, deprecate same module level consts
faern Dec 17, 2019
252c5f4
Use float associated constants
faern Dec 17, 2019
e6e7694
TMP (can be improved): Don't import integer modules
faern Dec 18, 2019
5a5c904
Allow deprecated in test specifically for primitive vs module fallback
faern Dec 18, 2019
32cfeef
up to 42 on num/mod
faern Jan 6, 2020
b3546c5
Remove invalid import
faern Jan 6, 2020
c73af28
Remove superfluous <> around usize
faern Jan 6, 2020
ab389e5
Use cmp::min instead of manual if-else
faern Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use cmp::min instead of manual if-else 
Co-Authored-By: lzutao <taolzu@gmail.com>
  • Loading branch information
@faern @tesuji
faern and tesuji committed Jan 6, 2020
commit ab389e5ed8e1b0389fc1ce86e168d6e145b65cdb
2 changes: 1 addition & 1 deletion src/libstd/sys/unix/condvar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const TIMESPEC_MAX: libc::timespec =
libc::timespec { tv_sec: <libc::time_t>::MAX, tv_nsec: 1_000_000_000 - 1 };

fn saturating_cast_to_time_t(value: u64) -> libc::time_t {
if value > <libc::time_t>::MAX as u64 { <libc::time_t>::MAX } else { value as libc::time_t }
crate::cmp::min(value, libc::time_t::MAX as u64) as _
}

impl Condvar {
Expand Down
2 changes: 1 addition & 1 deletion src/libstd/sys/vxworks/condvar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const TIMESPEC_MAX: libc::timespec =
libc::timespec { tv_sec: <libc::time_t>::MAX, tv_nsec: 1_000_000_000 - 1 };

fn saturating_cast_to_time_t(value: u64) -> libc::time_t {
if value > <libc::time_t>::MAX as u64 { <libc::time_t>::MAX } else { value as libc::time_t }
crate::cmp::min(value, libc::time_t::MAX as u64) as _
}

impl Condvar {
Expand Down