Skip to content

Parse the syntax described in RFC 2632 #67820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 10, 2020
Merged

Parse the syntax described in RFC 2632 #67820

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
63e2e44
Add `const_trait_impl` feature gate
ecstatic-morse Jan 2, 2020
6fc4158
Add `const_trait_bound_opt_out` feature gate
ecstatic-morse Jan 2, 2020
fd4a6a1
Add a `constness` field to `ast::TraitRef`
ecstatic-morse Jan 2, 2020
1c3fe9d
Parse `impl const Trait for Ty` syntax
ecstatic-morse Jan 2, 2020
0cf52a7
Parse `?const Trait` bound syntax
ecstatic-morse Jan 2, 2020
b390fc4
Error when new syntax is lowered
ecstatic-morse Jan 3, 2020
31edbe9
Reject `const` in inherent impls
ecstatic-morse Jan 4, 2020
d843e00
Check for `?const` in invalid contexts during AST validation
ecstatic-morse Jan 5, 2020
343e157
Add tests for RFC 2632
ecstatic-morse Jan 3, 2020
b6b11f0
Call all visit methods on trait definitions
ecstatic-morse Jan 5, 2020
9950a1f
Add test for `?const` and `?` on the same bound
ecstatic-morse Jan 5, 2020
14730ed
Make `bound_context` more like neighboring functions
ecstatic-morse Jan 6, 2020
fd1c003
Add test for `?const` in nested impl/dyn trait
ecstatic-morse Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test for ?const in nested impl/dyn trait
  • Loading branch information
@ecstatic-morse
ecstatic-morse committed Jan 10, 2020
commit fd1c00348b7b3521f7340a2d034b32406229fe1b
4 changes: 4 additions & 0 deletions src/test/ui/rfc-2632-const-trait-impl/const-trait-bound-opt-out/in-trait-object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,8 @@ fn trait_object() -> &'static dyn ?const T { &S }
//~^ ERROR `?const` is not permitted in trait objects
//~| ERROR `?const` on trait bounds is not yet implemented

fn trait_object_in_apit(_: impl IntoIterator<Item = Box<dyn ?const T>>) {}
//~^ ERROR `?const` is not permitted in trait objects
//~| ERROR `?const` on trait bounds is not yet implemented

fn main() {}
14 changes: 13 additions & 1 deletion src/test/ui/rfc-2632-const-trait-impl/const-trait-bound-opt-out/in-trait-object.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ error: `?const` is not permitted in trait objects
LL | fn trait_object() -> &'static dyn ?const T { &S }
| ^^^^^^^^

error: `?const` is not permitted in trait objects
--> $DIR/in-trait-object.rs:18:61
|
LL | fn trait_object_in_apit(_: impl IntoIterator<Item = Box<dyn ?const T>>) {}
| ^^^^^^^^

error: `?const` on trait bounds is not yet implemented
--> $DIR/in-trait-object.rs:10:6
|
Expand All @@ -22,5 +28,11 @@ error: `?const` on trait bounds is not yet implemented
LL | fn trait_object() -> &'static dyn ?const T { &S }
| ^^^^^^^^

error: aborting due to 4 previous errors
error: `?const` on trait bounds is not yet implemented
--> $DIR/in-trait-object.rs:18:61
|
LL | fn trait_object_in_apit(_: impl IntoIterator<Item = Box<dyn ?const T>>) {}
| ^^^^^^^^

error: aborting due to 6 previous errors