Support -Z ui-testing=yes/no
#67735
Merged
Support -Z ui-testing=yes/no
#67735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochenkov
added
the
S-waiting-on-review
|
@bors r+ code wise I think we generally prefer to shy away from such options -- do we have something pre-existing which we can cite here? I'm okay with this since it's an unstable flag intended purely for internal usage (i.e., not even nightly users should really be reaching for this). |
|
📌 Commit 208c1bf has been approved by |
bors
added
S-waiting-on-bors
At least anything using |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 31, 2019
Support `-Z ui-testing=yes/no` `ui-testing` is now a boolean option (`-Z ui-testing=yes/no`) and can be specified multiple times with later values overriding earlier values (`-Z ui-testing=yes -Z ui-testing=no` == `-Z ui-testing=no`), so it can be set in a hierarchical way, e.g. UI testing infra may enable it by default with specific tests being able to opt-out. This way we can remove the special opt-out support from `compiletest`. Inspired by rust-lang#67709.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 31, 2019
Support `-Z ui-testing=yes/no` `ui-testing` is now a boolean option (`-Z ui-testing=yes/no`) and can be specified multiple times with later values overriding earlier values (`-Z ui-testing=yes -Z ui-testing=no` == `-Z ui-testing=no`), so it can be set in a hierarchical way, e.g. UI testing infra may enable it by default with specific tests being able to opt-out. This way we can remove the special opt-out support from `compiletest`. Inspired by rust-lang#67709.
bors
added a commit
that referenced
this pull request
Dec 31, 2019
Rollup of 5 pull requests Successful merges: - #67430 (doc: minus (U+2212) instead of dash (U+002D) for negative infinity) - #67697 (Move the region_scope_tree query to librustc_passes.) - #67719 (Add self to .mailmap) - #67723 (Add error code explanation for E0477) - #67735 (Support `-Z ui-testing=yes/no`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui-testingis now a boolean option (-Z ui-testing=yes/no) and can be specified multiple times with later values overriding earlier values (-Z ui-testing=yes -Z ui-testing=no==-Z ui-testing=no), so it can be set in a hierarchical way, e.g. UI testing infra may enable it by default with specific tests being able to opt-out.This way we can remove the special opt-out support from
compiletest.Inspired by #67709.