Skip to content

Rollup of 10 pull requests #67080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Dec 6, 2019
Merged

Rollup of 10 pull requests #67080

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e20f630
pass the captured environment variables to rtpSpawn
BaoshanPang Nov 4, 2019
de362b4
ensure that access to the environment is synchronized
BaoshanPang Nov 20, 2019
481b18a
Small error codes explanation cleanup (E0092, E0093 and E0094)
GuillaumeGomez Nov 30, 2019
b1ececa
[CI] fix the `! isCI` check in src/ci/run.sh
cuviper Dec 2, 2019
7693bb9
Add long error for E0631 and update ui tests.
reese Dec 3, 2019
26a1ba8
Use simpler code example for E0631 long error.
reese Dec 3, 2019
3091b82
Tweak wording of `collect()` on bad target type
estebank Nov 26, 2019
79849ee
add ExitStatusExt into prelude
BaoshanPang Dec 3, 2019
911b7d6
Update missed test.
reese Dec 3, 2019
c911bb1
clean up E0107 error explanation
GuillaumeGomez Nov 30, 2019
c2ce7dd
Clean up E0116 error code long explanation
GuillaumeGomez Dec 4, 2019
1e5450d
Clean up E0117 error code long explanation
GuillaumeGomez Dec 4, 2019
9eaea4d
Clean up E0118 error code long explanation
GuillaumeGomez Dec 4, 2019
ae753a5
some error codes long explanation
GuillaumeGomez Dec 4, 2019
8be7223
Fix docs for formatting delegations
elichai Dec 4, 2019
28b37a2
Merge pull request #46 from Wind-River/master_base_V7LIBC-1069
n-salim Dec 5, 2019
f7789ad
Fix fetching arguments on the wasm32-wasi target
alexcrichton Dec 5, 2019
db7b0f8
Update the revision of wasi-libc used in wasm32-wasi
alexcrichton Dec 5, 2019
617b07e
Rollup merge of #66649 - Wind-River:master_xyz, r=alexcrichton
JohnTitor Dec 6, 2019
3d2cb55
Rollup merge of #66764 - estebank:reword-bad-collect, r=alexcrichton
JohnTitor Dec 6, 2019
c31773c
Rollup merge of #66900 - GuillaumeGomez:clean-up-err-codes, r=Dylan-DPC
JohnTitor Dec 6, 2019
3b878aa
Rollup merge of #66974 - cuviper:not-isCI, r=alexcrichton
JohnTitor Dec 6, 2019
6c0165f
Rollup merge of #66979 - reese:E0631-long-error, r=GuillaumeGomez
JohnTitor Dec 6, 2019
662a225
Rollup merge of #67017 - GuillaumeGomez:long-err-explanations-2, r=Dy…
JohnTitor Dec 6, 2019
f7c2631
Rollup merge of #67021 - elichai:2019-12-fmt, r=QuietMisdreavus
JohnTitor Dec 6, 2019
1bb868c
Rollup merge of #67041 - Wind-River:master_base, r=alexcrichton
JohnTitor Dec 6, 2019
f77b8d3
Rollup merge of #67065 - alexcrichton:update-wasi, r=sfackler
JohnTitor Dec 6, 2019
acd2b08
Rollup merge of #67066 - alexcrichton:update-wasi-libc, r=Mark-Simula…
JohnTitor Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[CI] fix the ! isCI check in src/ci/run.sh 
Using `if [ ! isCI ] || ...` doesn't run any command, just tests `isCI`
as a string, whereas `if ! isCI || ...` will actually run the `isCI`
command and negate its exit status.
  • Loading branch information
@cuviper
cuviper committed Dec 2, 2019
commit b1ececa669cf6b1481281efb580f2384dfcddfd5
2 changes: 1 addition & 1 deletion src/ci/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ fi
ci_dir=`cd $(dirname $0) && pwd`
source "$ci_dir/shared.sh"

if [ ! isCI ] || isCiBranch auto || isCiBranch beta; then
if ! isCI || isCiBranch auto || isCiBranch beta; then
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set build.print-step-timings --enable-verbose-tests"
fi

Expand Down