Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do min_const_fn checks for SetDiscriminants target #66790

Merged
merged 3 commits into from
Dec 1, 2019
Merged

Do min_const_fn checks for SetDiscriminants target #66790

merged 3 commits into from
Dec 1, 2019

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Nov 26, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Nov 30, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 30, 2019

📌 Commit 2ced9d9 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Nov 30, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 1, 2019
…ant, r=oli-obk

Do `min_const_fn` checks for `SetDiscriminant`s target

Fixes rust-lang#66556

r? @oli-obk @ecstatic-morse
bors added a commit that referenced this pull request Dec 1, 2019
Rollup of 9 pull requests

Successful merges:

 - #66503 (More useful test error messages on should_panic(expected=...) mismatch)
 - #66662 (Miri: run panic-catching tests in liballoc)
 - #66679 (Improve lifetime errors with implicit trait object lifetimes)
 - #66726 (Use recursion_limit for const eval stack limit)
 - #66790 (Do `min_const_fn` checks for `SetDiscriminant`s target)
 - #66832 (const_prop: detect and avoid catching Miri errors that require allocation)
 - #66880 (Add long error code explanation message for E0203)
 - #66890 (Format liballoc with rustfmt)
 - #66896 (pass Queries to compiler callbacks)

Failed merges:

r? @ghost
@bors bors merged commit 2ced9d9 into rust-lang:master Dec 1, 2019
@pvdrz pvdrz deleted the check-set-discriminant branch December 1, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

min const fn checks don't check set discriminant target
5 participants