Skip to content

mem::zeroed/uninit: panic on types that do not permit zero-initialization #66059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 11, 2020
Merged

mem::zeroed/uninit: panic on types that do not permit zero-initialization #66059

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
503026b
mem::zeroed/uninit: panic on types that do not permit zero-initializa…
RalfJung Nov 3, 2019
6fd909b
reference tracking issue
RalfJung Nov 6, 2019
d78c4aa
use valid_range_exclusive for correct overflow handling
RalfJung Nov 9, 2019
df6a3a0
test some more things that should not panic
RalfJung Nov 9, 2019
b133d67
make it even more conservative, and note some FIXMEs
RalfJung Nov 13, 2019
6e66f58
fmt
RalfJung Feb 16, 2020
729f4cd
we cannot short-circuit just becuase the Abi seems harmless
RalfJung Feb 17, 2020
bfe593e
clarify a comment in the test
RalfJung Feb 29, 2020
7c84e45
move panic intrinsic codegen to helper function
RalfJung Feb 29, 2020
a09c33e
move pattern to fn argument
RalfJung Feb 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify a comment in the test
  • Loading branch information
@RalfJung
RalfJung committed Feb 29, 2020
commit bfe593e03a0f73ee52ac666be17e963957ef628f
4 changes: 3 additions & 1 deletion src/test/ui/intrinsics/panic-uninitialized-zeroed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,9 @@ fn main() {
let _val = mem::zeroed::<MaybeUninit<NonNull<u32>>>();
let _val = mem::uninitialized::<MaybeUninit<bool>>();

// We don't panic for these just to be conservative. They are UB as of now (2019-11-09).
// These are UB because they have not been officially blessed, but we await the resolution
// of <https://github.com/rust-lang/unsafe-code-guidelines/issues/71> before doing
// anything about that.
let _val = mem::uninitialized::<i32>();
let _val = mem::uninitialized::<*const ()>();
}
Expand Down