Skip to content

Error explanation e0524 #64428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2019
Merged

Error explanation e0524 #64428

merged 2 commits into from
Sep 25, 2019

Conversation

@GuillaumeGomez
Copy link
Member

Part of #61137

@rust-highfive
Copy link
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2019
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 13, 2019
Closed
100 tasks
Centril
Centril reviewed Sep 13, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run --bless --compare-mode=nll.

src/librustc_mir/error_codes.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block not necessary with NLL.

@petrochenkov
Copy link
Contributor

r? @Centril

@Centril
Copy link
Contributor

Centril commented Sep 14, 2019

r=me with comments addressed.

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2019
@JohnCSimon
Copy link
Member

Ping from triage.
@GuillaumeGomez Hello! This PR has sat idle for about a week.
Thank you.

@GuillaumeGomez
Copy link
Member Author

Updated.

Please also run --bless --compare-mode=nll.

I did, no changes.

Centril
Centril reviewed Sep 21, 2019
View reviewed changes
src/librustc_mir/error_codes.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case, use reference countered types such as `Rc` (or `Arc` if it runs
case, use reference counted types such as `Rc` (or `Arc` if it runs

Oops, looks I just exchanged one typo for another. It's right now at least.

@Centril
Copy link
Contributor

Centril commented Sep 21, 2019

@GuillaumeGomez great; left another comment; the unnecessary block should also be removed and then r=me.

@GuillaumeGomez
Copy link
Member Author

@Centril I think the block makes the example simpler to understand (that's why I kept it, forgot to comment about it).

@GuillaumeGomez
Copy link
Member Author

Updated.

@Centril
Copy link
Contributor

Centril commented Sep 21, 2019

@GuillaumeGomez I see; can you add a comment noting that it isn't really necessary?

@GuillaumeGomez
Copy link
Member Author

Sure!

@GuillaumeGomez
Copy link
Member Author

Done!

@Centril
Copy link
Contributor

Centril commented Sep 23, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 23, 2019

📌 Commit d2b873b has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 23, 2019
@Centril
Rollup merge of rust-lang#64428 - GuillaumeGomez:error-explanation-E0…
5d8a8b6 
…524, r=Centril

Error explanation e0524

Part of rust-lang#61137
@Centril Centril mentioned this pull request Sep 23, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 24, 2019
@Centril
Rollup merge of rust-lang#64428 - GuillaumeGomez:error-explanation-E0…
8f9ad07 
…524, r=Centril

Error explanation e0524

Part of rust-lang#61137
@bors
Copy link
Collaborator

bors commented Sep 24, 2019

⌛ Testing commit d2b873b with merge efcf6044362591d7b89d89a7fa05bec6aa100569...

@Centril Centril mentioned this pull request Sep 24, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Sep 24, 2019

@bors retry rolled up.

@bors
Copy link
Collaborator

bors commented Sep 24, 2019

⌛ Testing commit d2b873b with merge 89471215346eeacf38185f7dc6d9e9df81e2276a...

@Centril
Copy link
Contributor

Centril commented Sep 24, 2019

@bors retry prioritizing stabilization PR.

Centril added a commit to Centril/rust that referenced this pull request Sep 25, 2019
@Centril
Rollup merge of rust-lang#64428 - GuillaumeGomez:error-explanation-E0…
0204f36 
…524, r=Centril

Error explanation e0524

Part of rust-lang#61137
@Centril Centril mentioned this pull request Sep 25, 2019
Merged
bors added a commit that referenced this pull request Sep 25, 2019
@bors
Auto merge of #64754 - Centril:rollup-iwtb5xd, r=Centril
b7820b2 
Rollup of 7 pull requests

Successful merges:

 - #64324 (rustc: Fix mixing crates with different `share_generics`)
 - #64428 (Error explanation e0524)
 - #64481 (A more explanatory thread local storage panic message)
 - #64599 (Rustdoc render async function re-export)
 - #64743 (Update cargo)
 - #64746 (Remove blanket silencing of "type annotation needed" errors)
 - #64753 (Don't emit explain with json short messages.)

Failed merges:

r? @ghost
@bors bors merged commit d2b873b into rust-lang:master Sep 25, 2019
@GuillaumeGomez GuillaumeGomez deleted the error-explanation-E0524 branch September 25, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Centril Centril Centril left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Centril Centril

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez @rust-highfive @petrochenkov @Centril @JohnCSimon @bors