Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume non-git LLVM is fresh if the stamp file exists #64156

Merged
merged 1 commit into from
Sep 6, 2019

Commits on Sep 4, 2019

  1. Assume non-git LLVM is fresh if the stamp file exists

    Rustbuild usually writes the LLVM submodule commit in a stamp file, so
    we can avoid rebuilding it unnecessarily. However, for builds from a
    source tarball (non-git), we were assuming a rebuild is always needed.
    This can cause a lot of extra work if any environment like `CFLAGS`
    changed between steps like build and install, which are often separate
    in distro builds.
    
    Now we also write an empty stamp file if the git commit is unknown, and
    its presence is trusted to indicate that no rebuild is needed. An info
    message reports that this is happening, along with the stamp file path
    that can be deleted to force a rebuild anyway.
    cuviper committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    53fe764 View commit details
    Browse the repository at this point in the history