-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix inconsistent highlight blocks. #62951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -547,10 +547,10 @@ impl char { | |
} | ||
} | ||
|
||
/// Returns `true` if this `char` satisfies the 'XID_Start' Unicode property, and false | ||
/// Returns `true` if this `char` satisfies the `XID_Start` Unicode property, and false | ||
/// otherwise. | ||
/// | ||
/// 'XID_Start' is a Unicode Derived Property specified in | ||
/// `XID_Start` is a Unicode Derived Property specified in | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep |
||
/// [UAX #31](http://unicode.org/reports/tr31/#NFKC_Modifications), | ||
/// mostly similar to `ID_Start` but modified for closure under `NFKx`. | ||
#[cfg_attr(bootstrap, | ||
|
@@ -563,12 +563,12 @@ impl char { | |
derived_property::XID_Start(self) | ||
} | ||
|
||
/// Returns `true` if this `char` satisfies the 'XID_Continue' Unicode property, and false | ||
/// Returns `true` if this `char` satisfies the `XID_Continue` Unicode property, and false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep |
||
/// otherwise. | ||
/// | ||
/// 'XID_Continue' is a Unicode Derived Property specified in | ||
/// `XID_Continue` is a Unicode Derived Property specified in | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep |
||
/// [UAX #31](http://unicode.org/reports/tr31/#NFKC_Modifications), | ||
/// mostly similar to 'ID_Continue' but modified for closure under NFKx. | ||
/// mostly similar to `ID_Continue` but modified for closure under NFKx. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep |
||
#[cfg_attr(bootstrap, | ||
unstable(feature = "rustc_private", | ||
reason = "mainly needed for compiler internals", | ||
|
@@ -666,7 +666,7 @@ impl char { | |
/// Returns `true` if this `char` is alphanumeric. | ||
/// | ||
/// 'Alphanumeric'-ness is defined in terms of the Unicode General Categories | ||
/// 'Nd', 'Nl', 'No' and the Derived Core Property 'Alphabetic'. | ||
/// `Nd`, `Nl`, `No` and the Derived Core Property `Alphabetic`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep |
||
/// | ||
/// # Examples | ||
/// | ||
|
@@ -720,7 +720,7 @@ impl char { | |
/// Returns `true` if this `char` is numeric. | ||
/// | ||
/// 'Numeric'-ness is defined in terms of the Unicode General Categories | ||
/// 'Nd', 'Nl', 'No'. | ||
/// `Nd`, `Nl`, `No`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep |
||
/// | ||
/// # Examples | ||
/// | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's clearer when reading the documentation to highlight this with backticks and it does refer to something which is code-like. At least if not with backticks it would be good to use 'XID_Start' to highlight more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Keep" means "keep the change to backticks".