Remove the '<->' operator #6260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The |
Contributor
|
needs a rebase |
Member
Author
|
Should be good to go again |
Contributor
|
Unfortunately this is bitrotted again :( |
Member
Author
|
Rebased for now at least, these keep creeping in... |
Member
Author
|
Well that's unfortunate, right after I pushed I wanted to make sure that the failing test from last time passed, and then I just forgot to check the output an hour later. This time the test actually passes! Perhaps the 5th time's the charm? |
bors
added a commit
that referenced
this pull request
May 11, 2013
There may be a more efficient implementation of `core::util::swap_ptr`. The issue mentioned using `move_val_init`, but I couldn't figure out what that did, so I just used `copy_memory` a few times instead. I'm not exactly the best at reading LLVM generated by rust, but this does appear to be optimized away just as expected (when possible).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 3, 2020
add a couple of ICE testcases Fixes rust-lang#6250 Fixes rust-lang#6251 Fixes rust-lang#6252 Fixes rust-lang#6255 Fixes rust-lang#6256 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a more efficient implementation of
core::util::swap_ptr. The issue mentioned usingmove_val_init, but I couldn't figure out what that did, so I just usedcopy_memorya few times instead.I'm not exactly the best at reading LLVM generated by rust, but this does appear to be optimized away just as expected (when possible).