Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Box<T> representation and its use in FFI #62514

Merged
merged 8 commits into from
Dec 12, 2019
Merged

Clarify Box<T> representation and its use in FFI #62514

merged 8 commits into from
Dec 12, 2019

Commits on Jul 10, 2019

  1. Clarify Box<T> representation and its use in FFI 

    This officializes what was only shown as a code example in [the unsafe code guidelines](https://rust-lang.github.io/unsafe-code-guidelines/layout/function-pointers.html?highlight=box#use) and follows [the discussion](rust-lang/unsafe-code-guidelines#157) in the corresponding repository.

It is also related to [the issue](rust-lang#52976) regarding marking `Box<T>` `#[repr(transparent)]`.
    @stephaneyfx
    stephaneyfx committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    318c5d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. Update Box representation comment based on reviews

    @stephaneyfx
    stephaneyfx committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    aea9423 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. Update FFI example 

    - Use meaningful names
- Clarify comments
- Fix C function declaration
    @stephaneyfx
    stephaneyfx committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    812ec6a View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Use Niko's wording

    @stephaneyfx
    stephaneyfx committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    ead1159 View commit details
    Browse the repository at this point in the history

  2. Specify behavior when passed a null pointer

    @stephaneyfx
    stephaneyfx committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    fe6ddd5 View commit details
    Browse the repository at this point in the history

  3. Remove trailing whitespace

    @stephaneyfx
    stephaneyfx committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    1a26df7 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Fix description based on review

    @stephaneyfx
    stephaneyfx committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    cb1cc11 View commit details
    Browse the repository at this point in the history

  2. clarify that Box<T> should only be used when defined *in Rust*

    Nicholas Matsakis committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    fafa489 View commit details
    Browse the repository at this point in the history