Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #61105

Merged
merged 41 commits into from
May 24, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
1e3302d
Suggest dereferencing on assignment to mutable borrow
estebank May 22, 2019
f44b264
fix dangling reference in Vec::append
RalfJung May 23, 2019
3cbf586
tweak discriminant on non-nullary enum diagnostic
euclio May 22, 2019
6116f19
Box::into_unique: do the reborrow-to-raw *after* destroying the Box
RalfJung May 23, 2019
8d4e7fd
adjust comment
RalfJung May 23, 2019
4ba144d
Update associated_item_def_ids
Zoxc Nov 30, 2018
8c936e4
Update inherent_impls
Zoxc Nov 30, 2018
99f6221
Update borrowck
Zoxc Nov 30, 2018
95dfd82
Update upstream_monomorphizations and upstream_monomorphizations_for
Zoxc Nov 30, 2018
093940d
Update implementations_of_trait and all_trait_implementations
Zoxc Nov 30, 2018
529aed8
Update resolve_lifetimes, named_region_map, is_late_bound_map and obj…
Zoxc Nov 30, 2018
b1398a0
Update item_children
Zoxc Nov 30, 2018
28482db
Update used_trait_imports
Zoxc Nov 30, 2018
ba5d9c0
Optimize alloc_from_iter
Zoxc Apr 23, 2019
ae8975c
Update GenericPredicates queries
Zoxc Dec 1, 2018
e77096b
Remove subtle Default impl for Value
Zoxc Apr 5, 2019
4214565
Add a comment for arena_types!
Zoxc May 19, 2019
ad2b35b
Make ArenaField private
Zoxc May 19, 2019
5bcc80b
Update Cargo.lock
Zoxc May 19, 2019
9dcc60b
Update lint_levels
Zoxc Nov 30, 2018
10ef70b
Update stability_index, all_crate_nums and features_query
Zoxc Nov 30, 2018
5751fcc
Update all_traits
Zoxc Nov 30, 2018
fb57879
Update privacy_access_levels
Zoxc Dec 1, 2018
5f808f6
Update in_scope_traits_map
Zoxc Dec 1, 2018
9b648f7
Update upvars and module_exports
Zoxc Dec 1, 2018
46f2511
Update wasm_import_module_map and target_features_whitelist
Zoxc Dec 1, 2018
3f87975
Update get_lib_features, defined_lib_features, get_lang_items, define…
Zoxc Dec 1, 2018
2f74d90
Update visible_parent_map
Zoxc Dec 1, 2018
469831f
Update foreign_modules and dllimport_foreign_items
Zoxc Dec 1, 2018
a58999c
Update dylib_dependency_formats, extern_crate and reachable_non_generics
Zoxc Dec 1, 2018
d46e732
Update crate_variances and inferred_outlives_crate
Zoxc May 20, 2019
7fbbcfa
Add regression test for negative case
estebank May 23, 2019
49f01d8
Fix missing overflowing literal lint in for loop
varkor May 23, 2019
3e4cefe
Update unreachable loop patterns test
varkor May 23, 2019
12de24c
Add test for denying overflowing literal in loop
varkor May 23, 2019
e0e9c86
Rollup merge of #59545 - Zoxc:the-arena-3, r=eddyb,michaelwoerister
Centril May 23, 2019
b9459e7
Rollup merge of #61054 - estebank:mut-ref-reassign, r=zackmdavis
Centril May 23, 2019
26f3528
Rollup merge of #61056 - euclio:custom-discriminant-error, r=estebank
Centril May 23, 2019
ee97210
Rollup merge of #61082 - RalfJung:vec, r=alexcrichton
Centril May 23, 2019
3388028
Rollup merge of #61086 - RalfJung:box, r=alexcrichton
Centril May 23, 2019
92fda92
Rollup merge of #61098 - varkor:fix-overflowing-literal-in-loop, r=es…
Centril May 23, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update item_children
  • Loading branch information
Zoxc committed May 23, 2019
commit b1398a0de67ce647f490c04a69cab0f76c649f9e
2 changes: 1 addition & 1 deletion src/librustc/query/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ rustc_queries! {
eval_always
desc { "fetching what a crate is named" }
}
query item_children(_: DefId) -> Lrc<Vec<Export<hir::HirId>>> {}
query item_children(_: DefId) -> &'tcx [Export<hir::HirId>] {}
query extern_mod_stmt_cnum(_: DefId) -> Option<CrateNum> {}

query get_lib_features(_: CrateNum) -> Lrc<LibFeatures> {
Expand Down
4 changes: 2 additions & 2 deletions src/librustc_metadata/cstore_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,9 @@ provide! { <'tcx> tcx, def_id, other, cdata,
}
crate_name => { cdata.name }
item_children => {
let mut result = vec![];
let mut result = SmallVec::<[_; 8]>::new();
cdata.each_child_of_item(def_id.index, |child| result.push(child), tcx.sess);
Lrc::new(result)
tcx.arena.alloc_slice(&result)
}
defined_lib_features => { Lrc::new(cdata.get_lib_features()) }
defined_lang_items => { Lrc::new(cdata.get_lang_items()) }
Expand Down
2 changes: 1 addition & 1 deletion src/librustdoc/clean/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4434,7 +4434,7 @@ pub fn path_to_def(tcx: TyCtxt<'_, '_, '_>, path: &[Symbol]) -> Option<DefId> {
loop {
let segment = path_it.next()?;

for item in mem::replace(&mut items, Lrc::new(vec![])).iter() {
for item in mem::replace(&mut items, &[]).iter() {
if item.ident.name == *segment {
if path_it.peek().is_none() {
return match item.res {
Expand Down