Stop -O/-C opt-level and -g/-C debuginfo conflicting
#60426
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| -include ../tools.mk | ||
|
|
||
| # FIXME: it would be good to check that it's actually the rightmost flags | ||
| # that are used when multiple flags are specified, but I can't think of a | ||
| # reliable way to check this. | ||
|
There was a problem hiding this comment. Can't we make There was a problem hiding this comment. (cc @varkor for his comment on #60426 (comment) which I read just now) |
||
|
|
||
| all: | ||
| # Test that `-O` and `-C opt-level` can be specified multiple times. | ||
| # The rightmost flag will be used over any previous flags. | ||
| $(RUSTC) -O -O main.rs | ||
| $(RUSTC) -O -C opt-level=0 main.rs | ||
| $(RUSTC) -C opt-level=0 -O main.rs | ||
| $(RUSTC) -C opt-level=0 -C opt-level=2 main.rs | ||
| $(RUSTC) -C opt-level=2 -C opt-level=0 main.rs | ||
|
|
||
| # Test that `-g` and `-C debuginfo` can be specified multiple times. | ||
| # The rightmost flag will be used over any previous flags. | ||
| $(RUSTC) -g -g main.rs | ||
| $(RUSTC) -g -C debuginfo=0 main.rs | ||
| $(RUSTC) -C debuginfo=0 -g main.rs | ||
| $(RUSTC) -C debuginfo=0 -C debuginfo=2 main.rs | ||
| $(RUSTC) -C debuginfo=2 -C debuginfo=0 main.rs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| fn main() {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.