Fix default value for setting "Auto-hide item methods' documentation" #60346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I open any documentation page in incognito mode (for example for
Option
enum), then methods will be collapsed, though on the settings page there will be displayed that "Auto-hide item methods' documentation" option is disabled.If I understand correctly, property "Auto-hide item methods' documentation" should be disabled by default, so correct check would be
property === "true"
. This is consistent with other options:Options which are enabled by default are compared to
"false"
rust/src/librustdoc/html/render.rs
Lines 1965 to 1968 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 2238 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 2321 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 2070 in 938d4ff
Options which are disabled by default are compared to
"true"
rust/src/librustdoc/html/render.rs
Lines 1970 to 1972 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 1389 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 2334 in 938d4ff