Skip to content

Rollup of 6 pull requests #60208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
53d2473
warn on unused results for operation methods on nums
KodrAus Apr 10, 2019
23154db
fix up unused wrappingn_add in compile-pass test
KodrAus Apr 10, 2019
e14819a
Update Source Serif Pro fonts to version 2.010
Manishearth Apr 21, 2019
6bafc58
Update Source Code Pro fonts to version 2.030
Manishearth Apr 21, 2019
cdca41d
Update Fira Sans to version 4.202
Manishearth Apr 21, 2019
517fb1b
Promote rust comments to rustdoc
rasendubi Apr 22, 2019
e55a313
Add rustc_allow_const_fn_ptr
cramertj Apr 5, 2019
795a15a
Stabilize futures_api
cramertj Apr 5, 2019
2d401fb
Add f16c target_feature
gnzlbg Apr 23, 2019
33f0a37
Look specifically for comments containing tidy ignore directives
varkor Apr 22, 2019
51b2ecf
Tidy warn on ignored line length when lines are not too long
varkor Apr 22, 2019
6283897
Remove unnecessary ignore-tidy-linelength
varkor Apr 22, 2019
497dcfa
Update ui tests
varkor Apr 22, 2019
7f7d15d
Check for other unused tidy check directives
varkor Apr 22, 2019
5392f44
Remove unnecessary tidy ignore directives
varkor Apr 22, 2019
5ab5806
Fix regression in line ending test
varkor Apr 23, 2019
76c7802
Rollup merge of #59739 - cramertj:stabilize, r=withoutboats
Centril Apr 23, 2019
4f125a6
Rollup merge of #59839 - KodrAus:must-use-num, r=sfackler
Centril Apr 23, 2019
1d2276f
Rollup merge of #60146 - Manishearth:font-update, r=QuietMisdreavus
Centril Apr 23, 2019
3006800
Rollup merge of #60169 - varkor:tidy-unnecessary-ignore-newline, r=ke…
Centril Apr 23, 2019
1d64312
Rollup merge of #60177 - rasendubi:rustdoc-comments, r=varkor
Centril Apr 23, 2019
97b74a5
Rollup merge of #60191 - gnzlbg:f16c, r=alexcrichton
Centril Apr 23, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ui tests
  • Loading branch information
varkor committed Apr 23, 2019
commit 497dcfa221b8bccf712b6f20a0ef038afbca3e4c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0502]: cannot borrow `x` as immutable because it is also borrowed as mutable
--> $DIR/two-phase-activation-sharing-interference.rs:32:15
--> $DIR/two-phase-activation-sharing-interference.rs:30:15
|
LL | let y = &mut x;
| ------ mutable borrow occurs here
Expand All @@ -10,7 +10,7 @@ LL | *y += 1;
| ------- mutable borrow later used here

error[E0502]: cannot borrow `x` as immutable because it is also borrowed as mutable
--> $DIR/two-phase-activation-sharing-interference.rs:40:13
--> $DIR/two-phase-activation-sharing-interference.rs:38:13
|
LL | let y = &mut x;
| ------ mutable borrow occurs here
Expand All @@ -21,7 +21,7 @@ LL | *y += 1;
| ------- mutable borrow later used here

error[E0502]: cannot borrow `x` as immutable because it is also borrowed as mutable
--> $DIR/two-phase-activation-sharing-interference.rs:51:13
--> $DIR/two-phase-activation-sharing-interference.rs:49:13
|
LL | let y = &mut x;
| ------ mutable borrow occurs here
Expand All @@ -32,7 +32,7 @@ LL | *y += 1;
| ------- mutable borrow later used here

error[E0502]: cannot borrow `x` as immutable because it is also borrowed as mutable
--> $DIR/two-phase-activation-sharing-interference.rs:62:14
--> $DIR/two-phase-activation-sharing-interference.rs:60:14
|
LL | let y = &mut x;
| ------ mutable borrow occurs here
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/consts/const-array-oob.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0080]: evaluation of constant value failed
--> $DIR/const-array-oob.rs:8:19
--> $DIR/const-array-oob.rs:6:19
|
LL | const BLUB: [u32; FOO[4]] = [5, 6];
| ^^^^^^ index out of bounds: the len is 3 but the index is 4
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/deprecation/deprecation-in-future.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
warning: use of deprecated item 'deprecated_future': text
--> $DIR/deprecation-in-future.rs:11:5
--> $DIR/deprecation-in-future.rs:9:5
|
LL | deprecated_future(); // ok; deprecated_in_future only applies to rustc_deprecated
| ^^^^^^^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/derives/deriving-meta-unknown-trait.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: cannot find derive macro `Eqr` in this scope
--> $DIR/deriving-meta-unknown-trait.rs:3:10
--> $DIR/deriving-meta-unknown-trait.rs:1:10
|
LL | #[derive(Eqr)]
| ^^^ help: try: `Eq`
Expand Down
16 changes: 8 additions & 8 deletions src/test/ui/discrim/discrim-overflow-2.stderr
Original file line number Diff line number Diff line change
@@ -1,61 +1,61 @@
error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow-2.rs:17:9
--> $DIR/discrim-overflow-2.rs:15:9
|
LL | OhNo,
| ^^^^ overflowed on value after 127
|
= note: explicitly set `OhNo = -128` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow-2.rs:26:9
--> $DIR/discrim-overflow-2.rs:24:9
|
LL | OhNo,
| ^^^^ overflowed on value after 255
|
= note: explicitly set `OhNo = 0` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow-2.rs:35:9
--> $DIR/discrim-overflow-2.rs:33:9
|
LL | OhNo,
| ^^^^ overflowed on value after 32767
|
= note: explicitly set `OhNo = -32768` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow-2.rs:44:9
--> $DIR/discrim-overflow-2.rs:42:9
|
LL | OhNo,
| ^^^^ overflowed on value after 65535
|
= note: explicitly set `OhNo = 0` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow-2.rs:53:9
--> $DIR/discrim-overflow-2.rs:51:9
|
LL | OhNo,
| ^^^^ overflowed on value after 2147483647
|
= note: explicitly set `OhNo = -2147483648` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow-2.rs:62:9
--> $DIR/discrim-overflow-2.rs:60:9
|
LL | OhNo,
| ^^^^ overflowed on value after 4294967295
|
= note: explicitly set `OhNo = 0` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow-2.rs:71:9
--> $DIR/discrim-overflow-2.rs:69:9
|
LL | OhNo,
| ^^^^ overflowed on value after 9223372036854775807
|
= note: explicitly set `OhNo = -9223372036854775808` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow-2.rs:80:9
--> $DIR/discrim-overflow-2.rs:78:9
|
LL | OhNo,
| ^^^^ overflowed on value after 18446744073709551615
Expand Down
16 changes: 8 additions & 8 deletions src/test/ui/discrim/discrim-overflow.stderr
Original file line number Diff line number Diff line change
@@ -1,61 +1,61 @@
error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow.rs:15:9
--> $DIR/discrim-overflow.rs:13:9
|
LL | OhNo,
| ^^^^ overflowed on value after 127
|
= note: explicitly set `OhNo = -128` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow.rs:26:9
--> $DIR/discrim-overflow.rs:24:9
|
LL | OhNo,
| ^^^^ overflowed on value after 255
|
= note: explicitly set `OhNo = 0` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow.rs:37:9
--> $DIR/discrim-overflow.rs:35:9
|
LL | OhNo,
| ^^^^ overflowed on value after 32767
|
= note: explicitly set `OhNo = -32768` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow.rs:48:9
--> $DIR/discrim-overflow.rs:46:9
|
LL | OhNo,
| ^^^^ overflowed on value after 65535
|
= note: explicitly set `OhNo = 0` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow.rs:60:9
--> $DIR/discrim-overflow.rs:58:9
|
LL | OhNo,
| ^^^^ overflowed on value after 2147483647
|
= note: explicitly set `OhNo = -2147483648` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow.rs:72:9
--> $DIR/discrim-overflow.rs:70:9
|
LL | OhNo,
| ^^^^ overflowed on value after 4294967295
|
= note: explicitly set `OhNo = 0` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow.rs:84:9
--> $DIR/discrim-overflow.rs:82:9
|
LL | OhNo,
| ^^^^ overflowed on value after 9223372036854775807
|
= note: explicitly set `OhNo = -9223372036854775808` if that is desired outcome

error[E0370]: enum discriminant overflowed
--> $DIR/discrim-overflow.rs:96:9
--> $DIR/discrim-overflow.rs:94:9
|
LL | OhNo,
| ^^^^ overflowed on value after 18446744073709551615
Expand Down
4 changes: 2 additions & 2 deletions src/test/ui/editions/edition-raw-pointer-method-2015.stderr
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
error: type annotations needed
--> $DIR/edition-raw-pointer-method-2015.rs:10:15
--> $DIR/edition-raw-pointer-method-2015.rs:9:15
|
LL | let _ = y.is_null();
| ^^^^^^^
|
note: lint level defined here
--> $DIR/edition-raw-pointer-method-2015.rs:6:8
--> $DIR/edition-raw-pointer-method-2015.rs:5:8
|
LL | #[deny(warnings)]
| ^^^^^^^^
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0699]: the type of this value must be known to call a method on a raw pointer on it
--> $DIR/edition-raw-pointer-method-2018.rs:10:15
--> $DIR/edition-raw-pointer-method-2018.rs:9:15
|
LL | let _ = y.is_null();
| ^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/error-codes/E0375.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0375]: implementing the trait `CoerceUnsized` requires multiple coercions
--> $DIR/E0375.rs:12:12
--> $DIR/E0375.rs:10:12
|
LL | impl<T, U> CoerceUnsized<Foo<U, T>> for Foo<T, U> {}
| ^^^^^^^^^^^^^^^^^^^^^^^^ requires multiple coercions
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0658]: the `#[ffi_returns_twice]` attribute is an experimental feature
--> $DIR/feature-gate-ffi_returns_twice.rs:5:5
--> $DIR/feature-gate-ffi_returns_twice.rs:4:5
|
LL | #[ffi_returns_twice]
| ^^^^^^^^^^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/ffi_returns_twice.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0724]: `#[ffi_returns_twice]` may only be used on foreign functions
--> $DIR/ffi_returns_twice.rs:5:1
--> $DIR/ffi_returns_twice.rs:4:1
|
LL | #[ffi_returns_twice]
| ^^^^^^^^^^^^^^^^^^^^
Expand Down
24 changes: 12 additions & 12 deletions src/test/ui/impl-trait/auto-trait-leak.stderr
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
error[E0391]: cycle detected when processing `cycle1::{{opaque}}#0`
--> $DIR/auto-trait-leak.rs:14:16
--> $DIR/auto-trait-leak.rs:12:16
|
LL | fn cycle1() -> impl Clone {
| ^^^^^^^^^^
|
note: ...which requires processing `cycle1`...
--> $DIR/auto-trait-leak.rs:14:1
--> $DIR/auto-trait-leak.rs:12:1
|
LL | fn cycle1() -> impl Clone {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
= note: ...which requires evaluating trait selection obligation `impl std::clone::Clone: std::marker::Send`...
note: ...which requires processing `cycle2::{{opaque}}#0`...
--> $DIR/auto-trait-leak.rs:23:16
--> $DIR/auto-trait-leak.rs:21:16
|
LL | fn cycle2() -> impl Clone {
| ^^^^^^^^^^
note: ...which requires processing `cycle2`...
--> $DIR/auto-trait-leak.rs:23:1
--> $DIR/auto-trait-leak.rs:21:1
|
LL | fn cycle2() -> impl Clone {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
= note: ...which requires evaluating trait selection obligation `impl std::clone::Clone: std::marker::Send`...
= note: ...which again requires processing `cycle1::{{opaque}}#0`, completing the cycle
note: cycle used when checking item types in top-level module
--> $DIR/auto-trait-leak.rs:3:1
--> $DIR/auto-trait-leak.rs:1:1
|
LL | / use std::cell::Cell;
LL | | use std::rc::Rc;
Expand All @@ -35,30 +35,30 @@ LL | | }
| |_^

error[E0391]: cycle detected when processing `cycle1::{{opaque}}#0`
--> $DIR/auto-trait-leak.rs:14:16
--> $DIR/auto-trait-leak.rs:12:16
|
LL | fn cycle1() -> impl Clone {
| ^^^^^^^^^^
|
note: ...which requires processing `cycle1`...
--> $DIR/auto-trait-leak.rs:14:1
--> $DIR/auto-trait-leak.rs:12:1
|
LL | fn cycle1() -> impl Clone {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
= note: ...which requires evaluating trait selection obligation `impl std::clone::Clone: std::marker::Send`...
note: ...which requires processing `cycle2::{{opaque}}#0`...
--> $DIR/auto-trait-leak.rs:23:16
--> $DIR/auto-trait-leak.rs:21:16
|
LL | fn cycle2() -> impl Clone {
| ^^^^^^^^^^
note: ...which requires processing `cycle2`...
--> $DIR/auto-trait-leak.rs:23:1
--> $DIR/auto-trait-leak.rs:21:1
|
LL | fn cycle2() -> impl Clone {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
= note: ...which again requires processing `cycle1::{{opaque}}#0`, completing the cycle
note: cycle used when checking item types in top-level module
--> $DIR/auto-trait-leak.rs:3:1
--> $DIR/auto-trait-leak.rs:1:1
|
LL | / use std::cell::Cell;
LL | | use std::rc::Rc;
Expand All @@ -70,15 +70,15 @@ LL | | }
| |_^

error[E0277]: `std::rc::Rc<std::string::String>` cannot be sent between threads safely
--> $DIR/auto-trait-leak.rs:17:5
--> $DIR/auto-trait-leak.rs:15:5
|
LL | send(cycle2().clone());
| ^^^^ `std::rc::Rc<std::string::String>` cannot be sent between threads safely
|
= help: within `impl std::clone::Clone`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<std::string::String>`
= note: required because it appears within the type `impl std::clone::Clone`
note: required by `send`
--> $DIR/auto-trait-leak.rs:6:1
--> $DIR/auto-trait-leak.rs:4:1
|
LL | fn send<T: Send>(_: T) {}
| ^^^^^^^^^^^^^^^^^^^^^^
Expand Down
12 changes: 6 additions & 6 deletions src/test/ui/impl-trait/auto-trait-leak2.stderr
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
error[E0277]: `std::rc::Rc<std::cell::Cell<i32>>` cannot be sent between threads safely
--> $DIR/auto-trait-leak2.rs:15:5
--> $DIR/auto-trait-leak2.rs:13:5
|
LL | send(before());
| ^^^^ `std::rc::Rc<std::cell::Cell<i32>>` cannot be sent between threads safely
|
= help: within `impl std::ops::Fn<(i32,)>`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<std::cell::Cell<i32>>`
= note: required because it appears within the type `[closure@$DIR/auto-trait-leak2.rs:9:5: 9:22 p:std::rc::Rc<std::cell::Cell<i32>>]`
= note: required because it appears within the type `[closure@$DIR/auto-trait-leak2.rs:7:5: 7:22 p:std::rc::Rc<std::cell::Cell<i32>>]`
= note: required because it appears within the type `impl std::ops::Fn<(i32,)>`
note: required by `send`
--> $DIR/auto-trait-leak2.rs:12:1
--> $DIR/auto-trait-leak2.rs:10:1
|
LL | fn send<T: Send>(_: T) {}
| ^^^^^^^^^^^^^^^^^^^^^^

error[E0277]: `std::rc::Rc<std::cell::Cell<i32>>` cannot be sent between threads safely
--> $DIR/auto-trait-leak2.rs:18:5
--> $DIR/auto-trait-leak2.rs:16:5
|
LL | send(after());
| ^^^^ `std::rc::Rc<std::cell::Cell<i32>>` cannot be sent between threads safely
|
= help: within `impl std::ops::Fn<(i32,)>`, the trait `std::marker::Send` is not implemented for `std::rc::Rc<std::cell::Cell<i32>>`
= note: required because it appears within the type `[closure@$DIR/auto-trait-leak2.rs:26:5: 26:22 p:std::rc::Rc<std::cell::Cell<i32>>]`
= note: required because it appears within the type `[closure@$DIR/auto-trait-leak2.rs:24:5: 24:22 p:std::rc::Rc<std::cell::Cell<i32>>]`
= note: required because it appears within the type `impl std::ops::Fn<(i32,)>`
note: required by `send`
--> $DIR/auto-trait-leak2.rs:12:1
--> $DIR/auto-trait-leak2.rs:10:1
|
LL | fn send<T: Send>(_: T) {}
| ^^^^^^^^^^^^^^^^^^^^^^
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0599]: no method named `is_empty` found for type `Foo` in the current scope
--> $DIR/method-suggestion-no-duplication.rs:9:15
--> $DIR/method-suggestion-no-duplication.rs:7:15
|
LL | struct Foo;
| ----------- method `is_empty` not found for this
Expand Down
4 changes: 2 additions & 2 deletions src/test/ui/issues/issue-21950.stderr
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
error[E0393]: the type parameter `Rhs` must be explicitly specified
--> $DIR/issue-21950.rs:7:14
--> $DIR/issue-21950.rs:5:14
|
LL | &Add;
| ^^^ missing reference to `Rhs`
|
= note: because of the default `Self` reference, type parameters must be specified on object types

error[E0191]: the value of the associated type `Output` (from the trait `std::ops::Add`) must be specified
--> $DIR/issue-21950.rs:7:14
--> $DIR/issue-21950.rs:5:14
|
LL | &Add;
| ^^^ associated type `Output` must be specified
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-22370.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0393]: the type parameter `T` must be explicitly specified
--> $DIR/issue-22370.rs:5:10
--> $DIR/issue-22370.rs:3:10
|
LL | fn f(a: &A) {}
| ^ missing reference to `T`
Expand Down
Loading