Skip to content

Rollup of 7 pull requests #59967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 14, 2019
Merged

Rollup of 7 pull requests #59967

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c440c0a
update polonius-engine
Apr 2, 2019
fd4c6e9
Remove duplicated redundant spans
estebank Apr 11, 2019
94a5c3b
Remove [mut] syntax in pin docs
czipperz Apr 12, 2019
ac5e755
Make BufWriter use get_mut instead of manipulating inner in Write imp…
czipperz Apr 12, 2019
e9c9d1c
Add comment that field projectin also works with mutable fields
czipperz Apr 12, 2019
ca5a9ce
Add test and fix dedup
estebank Apr 12, 2019
b754b8f
Expand note on mutable references
czipperz Apr 13, 2019
3b99a48
HirIdify hir::Def
ljedrz Apr 3, 2019
b5d43fc
Update tests
Zoxc Apr 11, 2019
3c3a140
Fix cross-crate visibility of fictive variant constructors
petrochenkov Apr 13, 2019
dbc7042
Address review comments
petrochenkov Apr 14, 2019
8f3fd85
Add missing backtick to Symbol documentation.
krk Apr 14, 2019
b9da8a7
Rollup merge of #59856 - albins:update-polonius, r=nikomatsakis
Centril Apr 14, 2019
27adc93
Rollup merge of #59877 - Zoxc:hiridify_def_id, r=eddyb
Centril Apr 14, 2019
99a9109
Rollup merge of #59896 - estebank:dedup-spans, r=davidtwco
Centril Apr 14, 2019
fd4a336
Rollup merge of #59900 - czipperz:remove-bracket-mut-syntax-in-pin-do…
Centril Apr 14, 2019
271eb8f
Rollup merge of #59906 - czipperz:bufwriter-use-getmut, r=kennytm
Centril Apr 14, 2019
9506f62
Rollup merge of #59936 - petrochenkov:confict, r=davidtwco
Centril Apr 14, 2019
c348bb6
Rollup merge of #59957 - krk:fix-doctypo-symbol, r=jonas-schievink
Centril Apr 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove duplicated redundant spans
  • Loading branch information
@estebank
estebank committed Apr 11, 2019
commit fd4c6e903b0161cedb2297e2de25783842dffe2b
7 changes: 3 additions & 4 deletions src/librustc_resolve/resolve_imports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,15 +1310,14 @@ impl<'a, 'b:'a> ImportResolver<'a, 'b> {
if !is_redundant.is_empty() &&
is_redundant.present_items().all(|is_redundant| is_redundant)
{
let mut redundant_spans: Vec<_> = redundant_span.present_items().collect();
redundant_spans.dedup();
self.session.buffer_lint_with_diagnostic(
UNUSED_IMPORTS,
directive.id,
directive.span,
&format!("the item `{}` is imported redundantly", ident),
BuiltinLintDiagnostics::RedundantImport(
redundant_span.present_items().collect(),
ident,
),
BuiltinLintDiagnostics::RedundantImport(redundant_spans, ident),
);
}
}
Expand Down