Update clippy

[mati865]

Fixes #59218

cc @Xanewok

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

⚠️ Warning ⚠️

• These commits modify submodules.

[Xanewok]

@mati865 As in rust-lang/rust-clippy#3893 (comment), could we also include:

• RLS bump to rust-lang/rls@90f7ab0
• Rustfmt bump to rust-lang/rustfmt@1427e4c

This should also update rustc-ap-* to v407

[Xanewok]

@bors delegate+

[bors]

✌️ @mati865 can now approve this pull request

[mati865]

Updating only changed submodules
Updating submodule src/tools/rustfmt
Submodules updated in 0.12 seconds
error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`

Caused by:
  patch for `rustfmt-nightly` in `https://github.com/rust-lang/crates.io-index` did not resolve to any crates. If this is unexpected, you may wish to consult: https://github.com/rust-lang/cargo/issues/4678
failed to run: /home/mateusz/Projects/rust/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /home/mateusz_arch/Projects/rust/rust/src/bootstrap/Cargo.toml

Looking into.

[Xanewok]

@mati865 remove https://github.com/rust-lang/rust/blob/225c5bf5dd4049c57ba88fdf73e2531aaff1f954/Cargo.lock#L3160-L3189 and try this again (this should prune old rustc-ap-* v373, RLS now only uses Rustfmt 1.1)

[mati865]

Finally old scoped-tls and parking_lot are dropped 🏆.

@bors r=Xanewok

[bors]

📌 Commit 986f88b has been approved by Xanewok

[Xanewok]

Nice, thanks!

@bors p=5

[bors]

⌛ Testing commit 986f88b with merge 7896c39eef41eb2b4d6543cae334743504d687ee...

[bors]

💔 Test failed - checks-travis

[rust-highfive]

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[02:15:54] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/cargotest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/ct"
[02:15:54] expected success, got: exit code: 101
[02:15:54] 
[02:15:54] 
[02:15:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/run-pass/pretty src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/test/run-pass-fulldeps/pretty src/tools/cargo src/tools/cargotest
[02:15:54] Build completed unsuccessfully in 0:41:47
[02:15:54] Makefile:50: recipe for target 'check-aux' failed
[02:15:54] make: *** [check-aux] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:14cf28f9
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Mar 18 21:23:42 UTC 2019
---
travis_time:end:179d8bfe:start=1552944226381190098,finish=1552944226388549384,duration=7359286
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:031bc7c8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:start:crashlog
obj/cores/core.4644.!checkout!obj!build!x86_64-unknown-linux-gnu!stage2!bin!rustc
[New LWP 4646]
[New LWP 4644]
warning: Could not load shared library symbols for 8 libraries, e.g. /lib/x86_64-linux-gnu/libc.so.6.
Use the "info sharedlibrary" command to see the complete listing.
Do you need "set solib-search-path" or "set sysroot"?
Core was generated by `rustc --crate-name foo src/lib.rs --color never --crate-type lib --emit=dep-inf'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007faea37b7428 in ?? ()
[Current thread is 1 (LWP 4646)]
#0  0x00007faea37b7428 in ?? ()
#1  0x00007faea37b902a in ?? ()
#2  0x0000000000000020 in ?? ()
#3  0x0000000000000000 in ?? ()
travis_time:end:031bc7c8:start=1552944226394094483,finish=1552944228571492161,duration=2177397678
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:040810b6
travis_time:start:040810b6
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0851b6c8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[Xanewok]

What I believe is the issue:

[02:15:54] error: failed to download from https://crates.io/api/v1/crates/filetime/0.1.10/download
[02:15:54]
[02:15:54] Caused by:
[02:15:54] failed to get 200 response from https://static.crates.io/crates/filetime/filetime-0.1.10.crate, got 504

@bors retry

[bors]

⌛ Testing commit 986f88b with merge ef4d1c4...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: Xanewok
Pushing ef4d1c4 to master...

[rust-highfive]

📣 Toolstate changed by #59279!

Tested on commit ef4d1c4.
Direct link to PR: #59279

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).