Skip to content

Do not panic on missing close paren #58863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Do not panic on missing close paren #58863

wants to merge 4 commits into from

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Mar 2, 2019

Fix #58856.

@estebank estebank added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 2, 2019
@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2019
@estebank
Copy link
Contributor Author

estebank commented Mar 2, 2019

r? @petrochenkov

estebank
estebank commented Mar 2, 2019
View reviewed changes
hdhoang
hdhoang reviewed Mar 2, 2019
View reviewed changes
Copy link
Contributor

@hdhoang hdhoang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very sorry about the mis-comment, I will try to revoke this

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 3, 2019

📌 Commit c4262bd has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2019
@estebank
Copy link
Contributor Author

estebank commented Mar 7, 2019

@bors p=51

@estebank estebank mentioned this pull request Mar 7, 2019
Merged
@estebank
Copy link
Contributor Author

estebank commented Mar 7, 2019

Added to #58903.

@estebank estebank closed this Mar 7, 2019
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hdhoang hdhoang hdhoang left review comments

@jethrogb jethrogb jethrogb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@estebank @rust-highfive @petrochenkov @bors @hdhoang @jethrogb @pnkfelix @pietroalbini