Skip to content

Rollup of 16 pull requests #58766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 40 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
d339468
improve unused doc comment diagnostic reporting
euclio Jan 23, 2019
b5fadf0
expand unused doc comment diagnostic
euclio Jan 24, 2019
890ef48
Fix an indexing error when using `x.py help`
varkor Feb 23, 2019
906ec8a
move collapse and unindent docs passes earlier
euclio Feb 20, 2019
1536852
merge early and late passes into single struct
euclio Feb 23, 2019
8300f51
Deny `async fn` in 2015 edition
cofibrant Feb 23, 2019
b7d4f96
rust-lldb: fix crash when printing empty string
euclio Feb 22, 2019
f1b88ab
Fix copy-pasted typo for read_string return value
shepmaster Feb 24, 2019
6c44bbb
Update dlmalloc to 0.1.3
Feb 26, 2019
eddd07c
Make `visit_clobber` panic-safe.
nnethercote Feb 22, 2019
abd88a9
Disable running several Stdio doctests
ipetkov Feb 26, 2019
5b97516
update scoped_tls to 1.0
Feb 26, 2019
992694a
reduce repetitions of (n << amt) >> amt
kenta7777 Feb 26, 2019
b23fd43
Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const
TimDiekmann Feb 26, 2019
56fb287
update Cargo.lock
hellow554 Feb 26, 2019
2d62619
Add `rustc_const_unstable` attribute
TimDiekmann Feb 26, 2019
4839d8c
Add tests
TimDiekmann Feb 26, 2019
6375efc
Update string_cache_codegen to 0.4.2
taiki-e Feb 26, 2019
278cb91
Satisfy tidy
TimDiekmann Feb 26, 2019
baea3c7
Use `cfg_attr` to prevent duplication
TimDiekmann Feb 26, 2019
c5f3830
Use const eval instead of const fn
TimDiekmann Feb 26, 2019
998896c
Clarify `rotate_{left,right}` docs
tbu- Feb 26, 2019
9b4055b
Normalize the type Self resolves to in an impl
Feb 26, 2019
c1f3d15
Changing error message to reflect changes with the 2018 edition
asettouf Feb 2, 2019
2349ec1
Rollup merge of #57882 - euclio:unused-doc-attributes, r=estebank
Centril Feb 27, 2019
57db958
Rollup merge of #58075 - asettouf:master, r=varkor
Centril Feb 27, 2019
0db8713
Rollup merge of #58627 - euclio:rustdoc-pass-order, r=QuietMisdreavus
Centril Feb 27, 2019
1bc0a62
Rollup merge of #58629 - euclio:debug-empty-str, r=alexcrichton
Centril Feb 27, 2019
ac3d8ef
Rollup merge of #58630 - nnethercote:fix-fold_clobber, r=petrochenkov
Centril Feb 27, 2019
275dc6c
Rollup merge of #58678 - doctorn:refuse-async-fn-2015-edition, r=varkor
Centril Feb 27, 2019
6f881b3
Rollup merge of #58680 - varkor:xpy-help-index-error, r=alexcrichton
Centril Feb 27, 2019
b8919af
Rollup merge of #58703 - shepmaster:read_line_return, r=centril
Centril Feb 27, 2019
d140738
Rollup merge of #58744 - jethrogb:jb/dlmalloc-0.1.3, r=alexcrichton
Centril Feb 27, 2019
e73e7a8
Rollup merge of #58746 - ipetkov:std-process-docs, r=cramertj
Centril Feb 27, 2019
bc0139c
Rollup merge of #58748 - hellow554:scoped_tls, r=estebank
Centril Feb 27, 2019
3f165af
Rollup merge of #58749 - kenta7777:reduce-repetition, r=oli-obk
Centril Feb 27, 2019
0dbd5e5
Rollup merge of #58750 - TimDiekmann:master, r=oli-obk
Centril Feb 27, 2019
149ff2a
Rollup merge of #58752 - taiki-e:update-string_cache_codegen, r=alexc…
Centril Feb 27, 2019
30e20a3
Rollup merge of #58755 - tbu-:pr_doc_clarifyrotate, r=Centril
Centril Feb 27, 2019
2055bff
Rollup merge of #58757 - aoikonomopoulos:issue-58212, r=oli-obk
Centril Feb 27, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/etc/lldb_rust_formatters.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,8 @@ def render_element(i):


def read_utf8_string(ptr_val, byte_count):
if byte_count == 0:
return '""'
error = lldb.SBError()
process = ptr_val.get_wrapped_value().GetProcess()
data = process.ReadMemory(ptr_val.as_integer(), byte_count, error)
Expand Down
33 changes: 33 additions & 0 deletions src/test/debuginfo/empty-string.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// compile-flags:-g
// min-gdb-version: 7.7
// min-lldb-version: 310

// === GDB TESTS ===================================================================================

// gdb-command: run

// gdb-command: print empty_string
// gdb-check:$1 = ""

// gdb-command: print empty_str
// gdb-check:$2 = ""

// === LLDB TESTS ==================================================================================

// lldb-command: run

// lldb-command: fr v empty_string
// lldb-check:[...]empty_string = ""

// lldb-command: fr v empty_str
// lldb-check:[...]empty_str = ""

fn main() {
let empty_string = String::new();

let empty_str = "";

zzz(); // #break
}

fn zzz() {}